Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rect of the divider block is incorrect #415

Merged
merged 4 commits into from
Aug 25, 2023

Conversation

LucasXu0
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Merging #415 (d57974d) into main (81186fa) will decrease coverage by 0.07%.
The diff coverage is 90.00%.

@@            Coverage Diff             @@
##             main     #415      +/-   ##
==========================================
- Coverage   80.60%   80.54%   -0.07%     
==========================================
  Files         255      255              
  Lines       10433    10441       +8     
==========================================
  Hits         8410     8410              
- Misses       2023     2031       +8     
Files Changed Coverage Δ
...vider_block_component/divider_block_component.dart 70.96% <0.00%> (ø)
...ent/image_block_component/image_upload_widget.dart 69.92% <100.00%> (ø)
...t/service/selection/desktop_selection_service.dart 82.20% <100.00%> (+0.15%) ⬆️

... and 5 files with indirect coverage changes

@LucasXu0 LucasXu0 merged commit a9af2bb into AppFlowy-IO:main Aug 25, 2023
q200892907 added a commit to q200892907/appflowy-editor that referenced this pull request Aug 28, 2023
* main: (48 commits)
  chore: comment suggesting use of deprecated method (AppFlowy-IO#417)
  fix: replace matches on the same node (AppFlowy-IO#418)
  fix: rect of the divider block is incorrect (AppFlowy-IO#415)
  chore: bump version 1.2.4 (AppFlowy-IO#414)
  feat: migrate copy paste command from AppFlowy (AppFlowy-IO#413)
  feat: added support for custom parser for markdown to document (AppFlowy-IO#403)
  feat: improve CJK IME support
  feat: add support for context menu items to the editor
  fix: refactor _onSelectionChange method to update _showPlaceholder state more efficiently
  fix: typo (AppFlowy-IO#408)
  Fix selected nodes (AppFlowy-IO#407)
  fix: miss the nested node when copying (AppFlowy-IO#406)
  feat: skip whitespace between words while navigating with CTRL+ARROW keys (AppFlowy-IO#363)
  feat: double hyphen to em dash (AppFlowy-IO#395)
  fix: add variable to hold editor selection for colour menu (AppFlowy-IO#400)
  test: open link command
  refactor: show link command test
  refactor: show link menu command
  feat: open link command
  fix: placeholder on paragraph when selected (AppFlowy-IO#390)
  ...
zoli added a commit to zoli/appflowy-editor that referenced this pull request Aug 28, 2023
…-state-update-node

* fix/previous-node-text-direction-null:
  feat: default text direction property (AppFlowy-IO#402)
  fix: fixed the cursor not moving to next line after inserting divider (AppFlowy-IO#371)
  chore: update theme colors for editor
  feat: refactor floating toolbar positioning logic
  fix: update resizable image width calculation with minimum width constraint
  chore: comment suggesting use of deprecated method (AppFlowy-IO#417)
  fix: replace matches on the same node (AppFlowy-IO#418)
  fix: rect of the divider block is incorrect (AppFlowy-IO#415)
  chore: bump version 1.2.4 (AppFlowy-IO#414)
  feat: migrate copy paste command from AppFlowy (AppFlowy-IO#413)
  feat: added support for custom parser for markdown to document (AppFlowy-IO#403)
  feat: improve CJK IME support
  feat: add support for context menu items to the editor
  fix: refactor _onSelectionChange method to update _showPlaceholder state more efficiently
  fix: typo (AppFlowy-IO#408)
  Fix selected nodes (AppFlowy-IO#407)
  fix: miss the nested node when copying (AppFlowy-IO#406)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant