Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: placeholder on paragraph when selected #390

Merged
merged 2 commits into from
Aug 17, 2023

Conversation

Xazin
Copy link
Collaborator

@Xazin Xazin commented Aug 16, 2023

Closes: #380

Preview

2023-08-16.18-32-51.mp4

@Xazin Xazin requested a review from LucasXu0 August 16, 2023 16:31
@Xazin Xazin force-pushed the fix/paragraph-placeholder branch from 675cb99 to a3d11f6 Compare August 17, 2023 07:27
@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Merging #390 (a3d11f6) into main (56474e8) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #390      +/-   ##
==========================================
+ Coverage   80.75%   80.78%   +0.02%     
==========================================
  Files         252      252              
  Lines       10258    10271      +13     
==========================================
+ Hits         8284     8297      +13     
  Misses       1974     1974              
Files Changed Coverage Δ
...tor/block_component/standard_block_components.dart 100.00% <100.00%> (ø)
...ent/text_block_component/text_block_component.dart 98.38% <100.00%> (+0.34%) ⬆️

@Xazin Xazin merged commit 61be737 into AppFlowy-IO:main Aug 17, 2023
q200892907 added a commit to q200892907/appflowy-editor that referenced this pull request Aug 28, 2023
* main: (48 commits)
  chore: comment suggesting use of deprecated method (AppFlowy-IO#417)
  fix: replace matches on the same node (AppFlowy-IO#418)
  fix: rect of the divider block is incorrect (AppFlowy-IO#415)
  chore: bump version 1.2.4 (AppFlowy-IO#414)
  feat: migrate copy paste command from AppFlowy (AppFlowy-IO#413)
  feat: added support for custom parser for markdown to document (AppFlowy-IO#403)
  feat: improve CJK IME support
  feat: add support for context menu items to the editor
  fix: refactor _onSelectionChange method to update _showPlaceholder state more efficiently
  fix: typo (AppFlowy-IO#408)
  Fix selected nodes (AppFlowy-IO#407)
  fix: miss the nested node when copying (AppFlowy-IO#406)
  feat: skip whitespace between words while navigating with CTRL+ARROW keys (AppFlowy-IO#363)
  feat: double hyphen to em dash (AppFlowy-IO#395)
  fix: add variable to hold editor selection for colour menu (AppFlowy-IO#400)
  test: open link command
  refactor: show link command test
  refactor: show link menu command
  feat: open link command
  fix: placeholder on paragraph when selected (AppFlowy-IO#390)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Must be some hint/label text for using editor
2 participants