Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: table html encoder and decoder added #449

Merged
merged 5 commits into from
Oct 22, 2023
Merged

feat: table html encoder and decoder added #449

merged 5 commits into from
Oct 22, 2023

Conversation

alihassan143
Copy link
Contributor

@alihassan143 alihassan143 commented Sep 11, 2023 •
edited
Loading

@codecov
Copy link

codecov bot commented Sep 11, 2023 •
edited
Loading

Codecov Report

Patch coverage: 83.72% and project coverage change: -0.04% ⚠️

Comparison is base (6d68f90) 80.53% compared to head (5b2c02f) 80.49%.
Report is 27 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #449      +/-   ##
==========================================
- Coverage   80.53%   80.49%   -0.04%     
==========================================
  Files         280      282       +2     
  Lines       11304    11887     +583     
==========================================
+ Hits         9104     9569     +465     
- Misses       2200     2318     +118
Files Changed Coverage Δ
lib/src/plugins/html/html_document_decoder.dart 87.77% <78.68%> (-2.76%) ⬇️
...plugins/html/encoder/parser/table_node_parser.dart 95.83% <95.83%> (ø)
lib/src/plugins/html/html_document.dart 100.00% <100.00%> (ø)

... and 75 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alihassan143
Copy link
Contributor Author

@LucasXu0 you can review this pr

@LucasXu0
Copy link
Collaborator

@zoli Please take a look.

@LucasXu0 LucasXu0 self-requested a review September 13, 2023 02:36
zoli
zoli suggested changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@zoli zoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me except for the comments. @alihassan143 Thanks for the effort.

lib/src/plugins/html/encoder/parser/table_node_parser.dart Outdated Show resolved Hide resolved
lib/src/plugins/html/html_document_decoder.dart Outdated Show resolved Hide resolved
test/plugins/html/encoder/parser/text_node_parser_test.dart Outdated Show resolved Hide resolved
lib/src/plugins/html/html_document_decoder.dart Outdated Show resolved Hide resolved
lib/src/plugins/html/html_document_decoder.dart Show resolved Hide resolved
lib/src/plugins/html/html_document_decoder.dart Outdated Show resolved Hide resolved
lib/src/plugins/html/html_document_decoder.dart Outdated Show resolved Hide resolved
@alihassan143
Copy link
Contributor Author

@zoli changes applied

@alihassan143 alihassan143 requested a review from zoli September 13, 2023 09:45
@alihassan143 alihassan143 requested a review from zoli September 20, 2023 10:44
zoli
zoli approved these changes Sep 20, 2023
View reviewed changes
Copy link
Contributor

@zoli zoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks.

@alihassan143
Copy link
Contributor Author

@LucasXu0 kindly check the pr @zoli approved the pr

@alihassan143
Copy link
Contributor Author

@LucasXu0

@alihassan143
Copy link
Contributor Author

@LucasXu0 any chance of this pr to be merged?

@LucasXu0 LucasXu0 merged commit 522f17a into AppFlowy-IO:main Oct 22, 2023
9 of 10 checks passed
@LucasXu0 LucasXu0 mentioned this pull request Oct 24, 2023
Merged
q200892907 added a commit to q200892907/appflowy-editor that referenced this pull request Oct 25, 2023
@q200892907
Merge branch 'main' into feat-zhiya
016ab9f 
* main:
  chore: bump version 1.5.0 (AppFlowy-IO#551)
  feat: convert = and > to ⇒ (AppFlowy-IO#523)
  feat: support overriding i18n (AppFlowy-IO#550)
  feat: table html encoder and decoder added (AppFlowy-IO#449)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zoli zoli zoli approved these changes

@LucasXu0 LucasXu0 Awaiting requested review from LucasXu0

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alihassan143 @LucasXu0 @zoli