Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support overriding i18n #550

Merged
merged 1 commit into from
Oct 24, 2023
Merged

feat: support overriding i18n #550

merged 1 commit into from
Oct 24, 2023

Conversation

LucasXu0
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Attention: 27 lines in your changes are missing coverage. Please review.

Comparison is base (89b93d8) 80.31% compared to head (3fa46ed) 80.33%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #550      +/-   ##
==========================================
+ Coverage   80.31%   80.33%   +0.02%     
==========================================
  Files         282      284       +2     
  Lines       12068    12153      +85     
==========================================
+ Hits         9692     9763      +71     
- Misses       2376     2390      +14     
Files Coverage Δ
...ent/divider_block_component/divider_menu_item.dart 25.00% <100.00%> (ø)
...ent/image_block_component/image_upload_widget.dart 78.66% <100.00%> (ø)
...tor/block_component/standard_block_components.dart 100.00% <100.00%> (ø)
...t/table_block_component/table_block_component.dart 54.90% <100.00%> (ø)
...tyle/mobile_text_span_decorator_for_attribute.dart 87.87% <100.00%> (ø)
lib/src/editor/l10n/appflowy_editor_l10n.dart 100.00% <100.00%> (ø)
.../editor/selection_menu/selection_menu_service.dart 76.28% <100.00%> (ø)
...lbar/desktop/items/bulleted_list_toolbar_item.dart 77.77% <100.00%> (ø)
...itor/toolbar/desktop/items/color/color_picker.dart 67.18% <100.00%> (ø)
...ktop/items/color/highlight_color_toolbar_item.dart 62.50% <100.00%> (ø)
... and 20 more

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LucasXu0 LucasXu0 merged commit 6d163b8 into AppFlowy-IO:main Oct 24, 2023
9 of 10 checks passed
q200892907 added a commit to q200892907/appflowy-editor that referenced this pull request Oct 25, 2023
* main:
  chore: bump version 1.5.0 (AppFlowy-IO#551)
  feat: convert = and > to ⇒ (AppFlowy-IO#523)
  feat: support overriding i18n (AppFlowy-IO#550)
  feat: table html encoder and decoder added (AppFlowy-IO#449)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant