Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable shift+press for selection range #512

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

Xazin
Copy link
Collaborator

@Xazin Xazin commented Oct 2, 2023

Closes: #31
Closes: AppFlowy-IO/AppFlowy#3579

@Xazin Xazin requested a review from LucasXu0 October 2, 2023 14:26
@Xazin Xazin changed the title feat: enable shift+priss for selection range feat: enable shift+press for selection range Oct 2, 2023
@Xazin Xazin force-pushed the feat/shift-press-for-selection branch from 2c7bd44 to aaeb37d Compare October 2, 2023 14:27
@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (0fdca2f) 80.43% compared to head (aaeb37d) 80.41%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #512      +/-   ##
==========================================
- Coverage   80.43%   80.41%   -0.03%     
==========================================
  Files         281      281              
  Lines       11856    11859       +3     
==========================================
  Hits         9536     9536              
- Misses       2320     2323       +3     
Files Coverage Δ
...t/service/selection/desktop_selection_service.dart 78.75% <36.36%> (-1.25%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Xazin Xazin merged commit b733864 into AppFlowy-IO:main Oct 2, 2023
8 of 10 checks passed
@Xazin Xazin deleted the feat/shift-press-for-selection branch October 2, 2023 18:18
q200892907 added a commit to q200892907/appflowy-editor that referenced this pull request Oct 7, 2023
* main:
  fix: image block revamp issues (AppFlowy-IO#517)
  chore: image block revamp (AppFlowy-IO#516)
  feat: enable shift+press for selection range (AppFlowy-IO#512)
  feat: make find and replace feature more customziable
  chore: rename replaceFlag to showReplaceMenu
  fix: the search service doesn't scroll to the position automatically
  feat: optimize the find and replace logic (AppFlowy-IO#510)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Shift-Click Selection [FR] Support shift + click to update selection from start to end position
2 participants