Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: image block revamp issues #517

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

LucasXu0
Copy link
Collaborator

@LucasXu0 LucasXu0 commented Oct 6, 2023

No description provided.

@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (e996c92) 80.41% compared to head (112409d) 80.41%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #517   +/-   ##
=======================================
  Coverage   80.41%   80.41%           
=======================================
  Files         281      281           
  Lines       11859    11863    +4     
=======================================
+ Hits         9536     9540    +4     
  Misses       2323     2323           
Files Coverage Δ
...ent/image_block_component/image_upload_widget.dart 78.66% <100.00%> (+0.43%) ⬆️
...component/service/ime/non_delta_input_service.dart 83.33% <100.00%> (+0.12%) ⬆️
...t/service/selection/desktop_selection_service.dart 78.64% <ø> (-0.12%) ⬇️
.../editor/selection_menu/selection_menu_service.dart 76.28% <100.00%> (+0.15%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LucasXu0 LucasXu0 merged commit af8d96b into AppFlowy-IO:main Oct 6, 2023
q200892907 added a commit to q200892907/appflowy-editor that referenced this pull request Oct 7, 2023
* main:
  fix: image block revamp issues (AppFlowy-IO#517)
  chore: image block revamp (AppFlowy-IO#516)
  feat: enable shift+press for selection range (AppFlowy-IO#512)
  feat: make find and replace feature more customziable
  chore: rename replaceFlag to showReplaceMenu
  fix: the search service doesn't scroll to the position automatically
  feat: optimize the find and replace logic (AppFlowy-IO#510)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant