fix: catch regex FormatException and show a corresponding error message
#573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #573 +/- ##
==========================================
- Coverage 80.54% 80.50% -0.04%
==========================================
Files 286 286
Lines 12182 12211 +29
==========================================
+ Hits 9812 9831 +19
- Misses 2370 2380 +10
☔ View full report in Codecov by Sentry. |
q200892907
added a commit
to q200892907/appflowy-editor
that referenced
this pull request
Nov 13, 2023
* main: chore: refactor mobile toolbar and divider block component (AppFlowy-IO#583) fix: don't rebuild mobile toolbar everytime (AppFlowy-IO#579) chore: bump version 1.5.2 (AppFlowy-IO#578) fix: quit editing button doesn't work (AppFlowy-IO#577) chore: changed padding values and added borderRadius (AppFlowy-IO#567) fix: catch regex `FormatException` and show a corresponding error message (AppFlowy-IO#573) fix: 'PageStorage.of' returns null (AppFlowy-IO#575) feat: Checkbox unresponsive in custom Theme example in editor example app (AppFlowy-IO#543)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.