Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't rebuild mobile toolbar every time #579

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

LucasXu0
Copy link
Collaborator

@LucasXu0 LucasXu0 commented Nov 7, 2023

No description provided.

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0bb39de) 80.50% compared to head (9cb9bc7) 80.50%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #579      +/-   ##
==========================================
- Coverage   80.50%   80.50%   -0.01%     
==========================================
  Files         286      286              
  Lines       12212    12211       -1     
==========================================
- Hits         9831     9830       -1     
  Misses       2381     2381              
Files Coverage Δ
lib/src/editor/toolbar/mobile/mobile_toolbar.dart 89.47% <ø> (-0.11%) ⬇️
...src/editor/toolbar/mobile/mobile_toolbar_item.dart 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LucasXu0 LucasXu0 merged commit a47fc6f into AppFlowy-IO:main Nov 7, 2023
10 checks passed
q200892907 added a commit to q200892907/appflowy-editor that referenced this pull request Nov 13, 2023
* main:
  chore: refactor mobile toolbar and divider block component (AppFlowy-IO#583)
  fix: don't rebuild mobile toolbar everytime (AppFlowy-IO#579)
  chore: bump version 1.5.2 (AppFlowy-IO#578)
  fix: quit editing button doesn't work (AppFlowy-IO#577)
  chore: changed padding values and added borderRadius (AppFlowy-IO#567)
  fix: catch regex `FormatException` and show a corresponding error message  (AppFlowy-IO#573)
  fix: 'PageStorage.of' returns null (AppFlowy-IO#575)
  feat: Checkbox unresponsive in custom Theme example in editor example app (AppFlowy-IO#543)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant