Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge CRAN package version to master #396

Merged
merged 61 commits into from
Nov 28, 2021
Merged

Merge CRAN package version to master #396

merged 61 commits into from
Nov 28, 2021

Conversation

jakubsob
Copy link
Contributor

@jakubsob jakubsob commented Nov 9, 2021

Merge CRAN package version to master

federiva and others added 30 commits January 11, 2021 18:30
@federiva
getting namespace from session context
6cd3a9f
@federiva
adding step
3c69095
@federiva
adding example
d93292d
@federiva
removing console.log
848195a
@federiva
minor - linting
7e94783
@federiva
Merge branch 'develop' into fede.session_context
d6160e4
@federiva
getting the namespace from the session object, adding asis as param
643413a
@federiva
fixing selector to be compatible when setting another class in the me…
c7b433f 
…nu_class arg of the tabset() function
@federiva
passing id to steps container
1ccd965
@federiva
making simple DOM changes as functions, automatic activation of next …
a05245e 
…steps, and resetting function
@federiva
documenting single_step
d96792b
@dokato
Merge pull request #349 from Appsilon/fede.tabset_fix
1580e38 
Fixing - Tabset won't work after changing its class trough the menu_class arg
Fixing standard sliders
0c952cc
Re-adding min for standard sliders
ee2f25c
@dokato
Merge pull request #352 from ashbaldry/bugfix/slider
5a3ef74 
Fixing standard sliders
@federiva
asis as TRUE for backwards compatibility
6affbdb
@dokato
Merge pull request #348 from Appsilon/fede.session_context
8cb2d5e 
Fede.session context
@jchojna
fix: assign variables to all parameters in grid function
ad159b3
@dokato
Merge pull request #355 from Appsilon/jakub.sidebar_layout_fix
a9eee28 
Fix sidebar_layout rendering by assigning variables to all parameters in grid function
@federiva
adding step example
277bc1a
@federiva
removing hr, removing ifelse
e6cb0fe
@federiva
adding simple unit test for step
4405cf6
@federiva
adding example to main app.R
25ee566
@dokato
Merge pull request #350 from Appsilon/fede.step
3a0c4df 
Fede.step
inline works for checkbox and radio
050c8b2
@ashbaldry
Checkbox uses Fomantic JS rather than shiny
4addd40
@ashbaldry
Enabled update of radio and checkboxes
dd2dc7b
@ashbaldry
Updating documentation and writing example
2ad2009
@dokato
Merge pull request #358 from ashbaldry/radio-update
769a418 
Multiple Checkbox/Radio Update
@dokato
Merge branch 'develop' into checkbox_inline
e77ec25
ARawles and others added 18 commits July 23, 2021 14:02
@ARawles
Improved textAreaInput example
256db9c
@federiva
Merge pull request #371 from ARawles/develop
f184da2 
Fixed `textAreaInput` value parameter
@aniaskrzydlo
Updated modal example
7fc5281
@aniaskrzydlo
Updated documentation
6466e2a
@aniaskrzydlo
Added standalone example
6c86116
@DamianBudelewski
feat: change way system dependencies are installed in the pipeline
f5801ee
@DamianBudelewski
Merge pull request #388 from Appsilon/feature/pipeline-improvement
c5cf02c 
feat: change way system dependencies are installed in the pipeline
@przytu1
Changed dev@appsilon.com to support+opensource@appsilon.com
8f3e6d2
@przytu1
Description updated
fbec76b
@aniaskrzydlo
Merge branch 'develop' into ania.update_modal_example
74ae56a 
merge develop
@aniaskrzydlo
Merge pull request #387 from Appsilon/ania.update_modal_example
ff73e45 
Ania.update modal example
Updated documentation for CRAN submission
6c6e62b
@jakubsob
Merge pull request #392 from Appsilon/cran-fixes
bae6b68 
R CMD check fixes
Adopt warn_unsupported_args to r-devel intersect implementation
801bf93 
In r-devel `intersect` returns NULL if any of arguments are NULL in contrast
to previous R versions in which `intersect` returned a vector of length 0
of a type same as given arguments
Fix R CMD check notes
cb29808 
- Updated links in DESCRIPTION and vignette
- Removed vignettes from .Rbuildignore
@jakubsob
Merge pull request #394 from Appsilon/cran-r-devel-fix
b57d200 
CRAN R-devel fix
Fix invalid URL note
2b08dc9
@jakubsob
Merge pull request #395 from Appsilon/cran-note-fix
229dbe7 
Fix invalid URL in vignette
jakubnowicki
jakubnowicki approved these changes Nov 9, 2021
View reviewed changes
Copy link
Member

@jakubnowicki jakubnowicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please make sure that CI update is included in this PR.

@jakubsob jakubsob removed the request for review from mdubel November 18, 2021 10:47
@jakubsob
Copy link
Contributor Author

Requires this PR to be merged first

@jakubsob
Merge pull request #399 from Appsilon/master
cf32bab 
Merge pull request #346 from Appsilon/develop
@przytu1 przytu1 closed this Nov 28, 2021
@przytu1 przytu1 reopened this Nov 28, 2021
@przytu1 przytu1 merged commit 9bb7d1d into master Nov 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubnowicki jakubnowicki jakubnowicki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.