Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type inconsistencies for methods with two generic types #266

Closed
DiscoPYF opened this issue Jul 11, 2020 · 0 comments · Fixed by #271
Closed

Type inconsistencies for methods with two generic types #266

DiscoPYF opened this issue Jul 11, 2020 · 0 comments · Fixed by #271
Assignees
@DiscoPYF
Labels
bug Something isn't working

Comments

@DiscoPYF
Copy link
Collaborator

DiscoPYF commented Jul 11, 2020 •
edited
Loading

Some methods have two generic parameters, e.g. T, U. This allows specifying a different document for the body and the response. However the types used for the body and the response are inconsistent across the APIs.

Example:

In DocumentApiClient, method PatchDocumentAsync<T, U> uses T for the body and U for the response.
In GraphApiClient, method PatchVertexAsync<T, U> uses T for the body and U for the response. But method PatchEdgeAsync<T, U> uses U for the body and T for the response.

We should check all methods and make sure T is used for the body and U for the response.
@DiscoPYF DiscoPYF changed the title Type inconsistencies across APIs for methods with two generic types Type inconsistencies for methods with two generic types Jul 11, 2020
@DiscoPYF DiscoPYF self-assigned this Jul 11, 2020
DiscoPYF added a commit to DiscoPYF/arangodb-net-standard that referenced this issue Jul 11, 2020
@DiscoPYF
Fix inconsistent usage of T and U types for body and response.
dcf51cb 
fix ArangoDB-Community#266
@DiscoPYF DiscoPYF mentioned this issue Jul 11, 2020
Merged
DiscoPYF added a commit to DiscoPYF/arangodb-net-standard that referenced this issue Jul 12, 2020
@DiscoPYF
Fix inconsistent usage of T and U types for body and response.
cd7d01b 
fix ArangoDB-Community#266
DiscoPYF added a commit to DiscoPYF/arangodb-net-standard that referenced this issue Jul 12, 2020
@DiscoPYF
Fix inconsistent usage of T and U types for body and response.
b207fec 
fix ArangoDB-Community#266
DiscoPYF added a commit to DiscoPYF/arangodb-net-standard that referenced this issue Jul 12, 2020
@DiscoPYF
Fix inconsistent usage of T and U types for body and response.
f744cd0 
fix ArangoDB-Community#266
@DiscoPYF DiscoPYF added the bug Something isn't working label Aug 12, 2020
DiscoPYF added a commit to DiscoPYF/arangodb-net-standard that referenced this issue Aug 15, 2020
@DiscoPYF
Fix inconsistent usage of T and U types for body and response.
10974ff 
fix ArangoDB-Community#266
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DiscoPYF DiscoPYF

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix inconsistent usage of T and U types for body and response. DiscoPYF/arangodb-net-standard
1 participant
@DiscoPYF