Fix inconsistent usage of T and U types for body and response. #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DiscoPYF
force-pushed
the
fixGenericTypes
branch
3 times, most recently
from
b207fec
to
f744cd0
Compare
|
Update: also changed the XML doc comments. |
rossmills99
approved these changes
Jul 13, 2020
|
Some bugs fixed here too by the look of it, good catch. |
rossmills99
approved these changes
Aug 13, 2020
DiscoPYF
force-pushed
the
fixGenericTypes
branch
from
f744cd0
to
10974ff
Compare
|
Update:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #266
I pulled a couple of changes from #270 and #268, please review/merge those first.
Tfor body andUfor response inGraphApiClient.PatchEdgeAsync<T, U>(that was the only one inconsistent)Tinstead ofUfor type name in response models