Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impossible to specify ApiClientSerializationOptions when patching an edge #426

Closed
JLedel opened this issue Oct 6, 2022 · 1 comment · Fixed by #437
Closed

Impossible to specify ApiClientSerializationOptions when patching an edge #426

JLedel opened this issue Oct 6, 2022 · 1 comment · Fixed by #437
Labels
bug Something isn't working

Comments

@JLedel
Copy link
Contributor

JLedel commented Oct 6, 2022

When posting a new edge, you can specify the serialization options to control the casing. However, in the methods used to patch an existing edge, there's no way to pass an options object used to serialize the edge data, and instead it's hard coded to use camel case. Is this the desired behaviour?

(There's also a bunch of different methods which seem to lack this parameter, and I can't seem to find a pattern on which method accepts it and which doesn't.)

We can provide a fix if this is something that should be changed.

@DiscoPYF DiscoPYF added the bug Something isn't working label Oct 24, 2022
@DiscoPYF
Copy link
Collaborator

DiscoPYF commented Oct 24, 2022

Hi @JLedel , thank you for reporting this issue.

Is this the desired behaviour?

Nope. @tjoubert and I had a look, it seems to be an oversight. I've classified this as a bug.

Methods that serialize a document provided by the caller should expose serialization options. We should add an ApiClientSerializationOptions parameter to the following methods:

  • PatchVertexAsync
  • PatchEdgeAsync
  • PutVertexAsync
  • PutEdgeAsync

I think we should place it before the GraphHeaderProperties parameter, to be in line with PostVertexAsync and PostEdgeAsync.

We can provide a fix if this is something that should be changed.

That would be great! We welcome contributions. See also contribution guide.

JLedel added a commit to JLedel/arangodb-net-standard that referenced this issue Oct 25, 2022
tjoubert added a commit that referenced this issue Nov 1, 2022
Fixes #426 Impossible to specify ApiClientSerializationOptions when patching an edge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants