Fixes #426 Impossible to specify ApiClientSerializationOptions when patching an edge #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tionOptions when patching an edge
DiscoPYF
approved these changes
Nov 1, 2022
| @@ -721,6 +725,8 @@ public virtual async Task<GetEdgeCollectionsResponse> GetEdgeCollectionsAsync(st | |||
| /// <param name="documentId">The document ID of the vertex to update.</param> | |||
| /// <param name="body"></param> | |||
| /// <param name="query"></param> | |||
| /// <param name="serializationOptions">The serialization options. When the value is null the | |||
There was a problem hiding this comment.
Maybe we should mention that the default serialization options apply when they are not provided here. Something like: "When the value is null the default options provided by the serializer are used."
The phrasing is the same as currently used elsewhere though, so not a big deal.
|
@JLedel, thanks for this contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if we want to do more to preserve backwards compatibility, but I guess the most common use case is to not specify these parameters which then shouldn't make this breaking. But I'll leave that to you to decide!