The doCenter method doesn't center correctly the popup when the popup is hidden #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fix build problems, then LGTM |
| elem.getStyle().clearLeft(); | ||
| elem.getStyle().clearTop(); | ||
|
|
||
| // the popup should be added to the dom in order to get correct values for offsetWidth/offsetHeight | ||
| if (!isShowing){ |
jDramaix
added a commit
that referenced
this pull request
Aug 8, 2013
The doCenter method doesn't center correctly the popup when the popup is hidden
jDramaix
added a commit
that referenced
this pull request
Apr 4, 2014
The doCenter method doesn't center correctly the popup when the popup is hidden
hpehl
pushed a commit
to hpehl/GWTP
that referenced
this pull request
Dec 9, 2014
The doCenter method doesn't center correctly the popup when the popup is hidden Former-commit-id: b5c0acc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The doCenter method is called twice when the popup presenter is revealed. The first time the method is called the popupPanel is hidden and the offsetWidth/ offsetHeight returns 0. The popuppanel is not correctly centered.
When the second call is done (in a deferred command) the popup is visible and so is correctly centered. But it looks like the popup jumps from the bottom right corner to the center. Furthermore if the developer is trying to align another widget with the popup (a tooltip for example) during the on reveal, the elements is misplaced.