Fixed PopupPresenter setCloseHandler #544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -161,11 +161,16 @@ protected void doCenter() { | |||
| int top = (Window.getClientHeight() - popup.getOffsetHeight()) >> 1; | |||
There was a problem hiding this comment.
I think the bit shift is too complex / 2 would be more readable.
|
LGTM |
| getView().setCloseHandler(closeHandler); | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
rm 39, you seem to have two line at eof
|
Is this ready to be merged? I want to make some changes to the PopupView interface and this is blocking me. |
|
In any cases, if you want to do changes to popup, now is the time :D |
meriouma
added a commit
that referenced
this pull request
Aug 24, 2014
Fixed PopupPresenter setCloseHandler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #497
The popup.hide() calls throws a CloseEvent, which is not what we want. This is a bit hacky but @jDramaix added the popup.show() and popup.hide() calls, which are probably required for #302. It doesn't seems like there's a way to properly hide the popup without calling the hide() method except by using the JSNI hack. Thoughts?