Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: add Location.is_event property #2968

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Core: add Location.is_event property #2968

merged 1 commit into from
Apr 11, 2024

Conversation

alwaysintreble
Copy link
Collaborator

What is this fixing or adding?

Title. Location.event kept being used this way so it probably make sense to have a proper shorthand convenience property.

How was this tested?

Wasn't

If this makes graphical changes, please attach screenshots.

@github-actions github-actions bot added affects: core Issues/PRs that touch core and may need additional validation. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Mar 16, 2024
@Jouramie
Copy link
Contributor

Yes please. LGTM!

NewSoupVi
NewSoupVi approved these changes Mar 19, 2024
View reviewed changes
Copy link
Member

@NewSoupVi NewSoupVi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup

@hatkirby hatkirby added waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. and removed waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Mar 20, 2024
silasary
silasary approved these changes Mar 24, 2024
View reviewed changes
Copy link
Contributor

@silasary silasary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems useful

@Exempt-Medic Exempt-Medic added the is: enhancement Issues requesting new features or pull requests implementing new features. label Apr 8, 2024
@Berserker66 Berserker66 merged commit 5dcafac into ArchipelagoMW:main Apr 11, 2024
15 checks passed
EmilyV99 pushed a commit to EmilyV99/Archipelago that referenced this pull request Apr 15, 2024
@alwaysintreble @EmilyV99
Core: add Location.is_event property (ArchipelagoMW#2968)
6c395d3
EmilyV99 pushed a commit to EmilyV99/Archipelago that referenced this pull request Apr 15, 2024
@alwaysintreble @EmilyV99
Core: add Location.is_event property (ArchipelagoMW#2968)
5251989
qwint pushed a commit to qwint/Archipelago that referenced this pull request Jun 24, 2024
@alwaysintreble @qwint
Core: add Location.is_event property (ArchipelagoMW#2968)
ba0b8cd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NewSoupVi NewSoupVi NewSoupVi approved these changes

@Jouramie Jouramie Jouramie approved these changes

@Ixrec Ixrec Ixrec approved these changes

@Berserker66 Berserker66 Berserker66 approved these changes

@silasary silasary silasary approved these changes

Assignees
No one assigned
Labels
affects: core Issues/PRs that touch core and may need additional validation. is: enhancement Issues requesting new features or pull requests implementing new features. waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@alwaysintreble @Jouramie @silasary @Berserker66 @Ixrec @NewSoupVi @hatkirby @Exempt-Medic