The Witness: The big dumb refactor #3007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
waiting-on: peer-review
NewSoupVi
added
the
is: refactor/cleanup
|
For any potential reviewers: There is 0 new code here apart from new import statements. Everything has just been shifted around, reformatted, or moved to new files / different folders. |
|
Included the Made sure it actually passes, except for one thing that will be addressed by this PR: #3049 |
Exempt-Medic
reviewed
Apr 5, 2024
Exempt-Medic
approved these changes
Apr 5, 2024
There was a problem hiding this comment.
Carefully read through all the changes, merged into main and generated five hundred 10-player games and one thousand single- and two-player games. Compared 0.4.5 and refactor spoiler logs (they were same except for playthrough) and walked through the playthrough checking for errors.
ScipioWright
approved these changes
Apr 5, 2024
ScipioWright
added
waiting-on: core-review
Co-authored-by: Scipio Wright <scipiowright@gmail.com>
This was referenced Apr 7, 2024
Berserker66
approved these changes
Apr 11, 2024
EmilyV99
pushed a commit
to EmilyV99/Archipelago
that referenced
this pull request
Apr 15, 2024
EmilyV99
pushed a commit
to EmilyV99/Archipelago
that referenced
this pull request
Apr 15, 2024
qwint
pushed a commit
to qwint/Archipelago
that referenced
this pull request
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The structure of The Witness is some actual hot trash. Also it violates style a lot. Also it uses old APIs.
ruff --fixregioandlocat