Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Witness: Increase variety of the starting item #3047

Merged
merged 2 commits into from
Apr 18, 2024

Conversation

NewSoupVi
Copy link
Member

@NewSoupVi NewSoupVi commented Mar 28, 2024

Someone complained that they always get the same two items on their Tutorial Gate

So I looked at the code and was like "Maybe I overthought this one"

Shapers and Stars don't always unlock something in sphere 1 but neither does Symmetry, and all of those items still feel important and will usually be relevant soon after starting

Someone complained that they always get the same item on their first check

So I looked at the code and was like "Maybe I overthought this one"

Shapers and Stars don't always unlock something in sphere 1 but neither does Symmetry, and those items still feel important and will usually be relevant soon after starting
@NewSoupVi NewSoupVi added the is: enhancement Issues requesting new features or pull requests implementing new features. label Mar 28, 2024
@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Mar 28, 2024
Copy link
Member

@Exempt-Medic Exempt-Medic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks fine. Tested the changes locally and they worked

@NewSoupVi NewSoupVi added waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. and removed waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Mar 29, 2024
@NewSoupVi NewSoupVi added waiting-on: other Issue/PR is waiting for something else, like another PR. and removed waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. labels Apr 7, 2024
@NewSoupVi
Copy link
Member Author

This PR might conflict with #3007, which I absolutely need to be merged before anything else, so I'm putting this one on "waiting on: other".

@Exempt-Medic Exempt-Medic added waiting-on: author Issue/PR is waiting for feedback or changes from its author. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. and removed waiting-on: other Issue/PR is waiting for something else, like another PR. labels Apr 11, 2024
@NewSoupVi NewSoupVi added waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. and removed waiting-on: author Issue/PR is waiting for feedback or changes from its author. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Apr 11, 2024
@Berserker66 Berserker66 merged commit 1faaa0d into ArchipelagoMW:main Apr 18, 2024
15 checks passed
qwint pushed a commit to qwint/Archipelago that referenced this pull request Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: enhancement Issues requesting new features or pull requests implementing new features. waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants