Issue #39: Save Comic id on Characters Entity #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Comics Entity. - Created strategy to save the comics id on the Characters entity. Signed-off-by: Diego Recalde <difereto89@gmail.com>
data/src/main/java/com/architect/coders/mu8/data/characters/CharactersDAO.kt
Show resolved
Hide resolved
jamacado
approved these changes
Jan 10, 2020
jamacado
added a commit
that referenced
this pull request
Jan 22, 2020
delete charactersUiModel because implemented databinding. Create diferent bindingAdapter for use in xml. Create Event for use navigation. javier.mcardona@gmail.com Issue #39: Save Comic id on Characters Entity & Save Character id on Comics Entity. (#46) - Created strategy to save the comics id on the Characters entity. Signed-off-by: Diego Recalde <difereto89@gmail.com> se quitan espacios change version database for 2 add builder database fallbacktoDestuctiveMigration
aliceresponde
pushed a commit
that referenced
this pull request
Jan 29, 2020
* Data Binding on Characters Activity #37 delete charactersUiModel because implemented databinding. Create diferent bindingAdapter for use in xml. Create Event for use navigation. javier.mcardona@gmail.com Issue #39: Save Comic id on Characters Entity & Save Character id on Comics Entity. (#46) - Created strategy to save the comics id on the Characters entity. Signed-off-by: Diego Recalde <difereto89@gmail.com> se quitan espacios change version database for 2 add builder database fallbacktoDestuctiveMigration * create small methods in create * change toolbar in activity and create livedata for title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in:
Testing Done:
How it looks:
How to test:
Run the app and reach the home screen.
Before entering to the Characters screen put a breakpoint in line
57of methodupdateUiinsideCharactersActivityclass as shown on the image below.Now enter to the Characters screen and upon reaching the breakpoint, check that the characters inside the model have now a list of ids for the comics the hero appears.
Check that the functionality of the app remains the same for this and the other categories.
Signed-off-by: