Issue #37: Data Binding on Characters Activity #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
recaldev
requested changes
Jan 15, 2020
presentation/src/main/java/com/architect/coders/mu8/characters/CharactersActivity.kt
Outdated
Show resolved
Hide resolved
presentation/src/main/java/com/architect/coders/mu8/characters/CharactersActivity.kt
Show resolved
Hide resolved
presentation/src/main/java/com/architect/coders/mu8/characters/CharactersBindingAdapters.kt
Outdated
Show resolved
Hide resolved
presentation/src/main/java/com/architect/coders/mu8/utils/BindingAdapters.kt
Show resolved
Hide resolved
recaldev
changed the title
recaldev
reviewed
Jan 15, 2020
presentation/src/main/java/com/architect/coders/mu8/characters/CharactersAdapter.kt
Outdated
Show resolved
Hide resolved
delete charactersUiModel because implemented databinding. Create diferent bindingAdapter for use in xml. Create Event for use navigation. javier.mcardona@gmail.com Issue #39: Save Comic id on Characters Entity & Save Character id on Comics Entity. (#46) - Created strategy to save the comics id on the Characters entity. Signed-off-by: Diego Recalde <difereto89@gmail.com> se quitan espacios change version database for 2 add builder database fallbacktoDestuctiveMigration
jamacado
force-pushed
the
mu8/javier/issue37-databinding-characters-activty
branch
from
54b316e
to
4a291fa
Compare
…/MU8 into mu8/javier/issue37-databinding-characters-activty # Conflicts: # data/src/main/java/com/architect/coders/mu8/data/mapper/common/UrlsMapper.kt # data/src/main/java/com/architect/coders/mu8/data/service/MarvelServiceAPI.kt # domain/src/main/java/com/architect/codes/mu8/characters/Character.kt # presentation/src/main/java/com/architect/coders/mu8/characters/CharactersActivity.kt # presentation/src/main/res/values/dimens.xml
data/src/main/java/com/architect/coders/mu8/data/database/MU8Database.kt
Show resolved
Hide resolved
recaldev
approved these changes
Jan 29, 2020
aliceresponde
deleted the
mu8/javier/issue37-databinding-characters-activty
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Data Binding on Characters Activity #37
Testing Done:
How to test:
Signed-off-by: