Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android studio svg to xml convert #1824

Conversation

Kaiserdragon2
Copy link
Collaborator

@Kaiserdragon2 Kaiserdragon2 commented Nov 22, 2023

Convert Svgs at build time to xml drawables with android studios built in converter
add xml icon support for light and dark(disabled for now)
fix clock color in light
move some drawables (drawables that aren't icons are now all in one place /drawables for each version)

@Donnnno
Copy link
Collaborator

Donnnno commented Nov 22, 2023

Dark/Light are not XML because some popular launchers don't support that format. I'd rather keep it that way for now.

@Kaiserdragon2
Copy link
Collaborator Author

I can disable that option.
Could you give me some examples which launchers don't support it. i would like to test these.

@TotallyAvailable
Copy link
Contributor

Jumping in without proper overview of the current situation.

Is there any change in terms of broader compatibility to be expected in the near future ?
Is the lack of current compatibility more of a legacy thing or is XML support just a fancy feature to have. Might it even be a bit of a lack of usage/demand case for the support to become a standard. Could Arcticons realistically change that ?

My actual question...what kind of benefits could the user expect vs the potential downsides of keeping 2 versions (XML only as GitHub release) going for the time being ?

@Kaiserdragon2
Copy link
Collaborator Author

Kaiserdragon2 commented Nov 23, 2023

Mostly generating the xml icons is much faster then the png when generating the release also the file size is much smaller. Generating all 8000 icons for the you version takes on my pc arround 20 seconds for the png it takes for just a few icons over a minute. I just prepared the xml functionality with these changes mostly this change is for the use of the android studio built in converter for the you Version.

@TotallyAvailable
Copy link
Contributor

TotallyAvailable commented Nov 23, 2023

The filesize plays into my thought on a recent Issue involving people using more than 1 Arcticon Version and the 3 Files in 1 Release situation here on GitHub. (regarding Obtainium - #1814)
(As for including it in APKUpdater, could work, assuming that's already part of a user's strategy towards more independence.
Taking a look at https://github.com/rumboalla/apkupdater/blob/3.x/app/src/main/kotlin/com/apkupdater/data/github/GitHubApp.kt might actually make that a potentially straight forward solution.
Another way as already suggested and done by https://github.com/1fexd/LinkSheetNightly - Release only repo)

While I suggested a couple Workarounds that can work, you would still be in a bit of a mismatch depending on the starting point.
None of this applies to Play Store users of course.

The end solution here obviously has the goal of least disruption possible.

Given that You is RB allowing for free source selection, how about a potential introduction/transition to an XML version hosted by Izzy. Would drop the version mismatch and manual work completely, no issues with filesize limits either.
Still leaves the eventual issue with the original F-Droid listing. As I'm not sure how they woud like/handle 2 seperate listings for Apps with identical Package Names (re-introduction allowing full RB support, 1 listing 2 (Signature) versions even ?) to not leave current users stranded.
Assuming the original listing stays, there's now the Signature conflict that should be avoided in F-Droid+Izzy double listings.

Lots of thoughts on things I have absolutely no say in of course, but in the name of 'open', 'coverage' and 'convenience' and "partially impacted" user myself...might as well be the voice of the at least two other users out there that would like to move further away from whatever the f*ck Google is doing with the Play Store, in a somewhat streamlined way.

F-Droid can, could and maybe should be seen as already existing solution, that's why I mention it here again.
Another door just opened, slightly shifting the "work vs benefits" side of things.

(Just a thought dump and not meant to mess with the goal of your PR)

@Kaiserdragon2
Copy link
Collaborator Author

i don,t even think that xml icons will make any problems on any launcher because the drawables are handled by android it self in most cases.

@Kaiserdragon2 Kaiserdragon2 marked this pull request as ready for review November 25, 2023 10:23
@xprateek
Copy link
Contributor

  • Actually runtime Drawables conversion great need to test in multiple launchers / same concept used in lawnicons afaik

lemme know for beta testing happy to help in free time!

@TotallyAvailable
Copy link
Contributor

Might as well link the initial test round here #1832

@Donnnno
Copy link
Collaborator

Donnnno commented Dec 15, 2023

Probably gonna postpone this till MS Launcher gets their shit together

@TotallyAvailable
Copy link
Contributor

In other words the day they end support for it. Will Arcticons still be around then ?

Given that plenty of (older) Launcher support it without there being that much demand currently, it doesn't appear to be all that difficult unless you actively want to make it not work. Without inside look on the actual goal of what the launcher is supposed to be/stand for, I can't really picture any obvious reason for actively not supporting it. Obviously nothing new when it comes to decisions made by big companies.

@xprateek
Copy link
Contributor

better to create new dev branch soo new variant SVG → XML keep updating during Christmas time.

AS Microsoft Being Microsoft they only change when required....

@Kaiserdragon2 Kaiserdragon2 deleted the AndroidStudioSvgtoXmlConvert branch February 13, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants