-
-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android studio svg to xml convert #1824
Android studio svg to xml convert #1824
Conversation
xml files are created at build time
Dark/Light are not XML because some popular launchers don't support that format. I'd rather keep it that way for now. |
I can disable that option. |
Jumping in without proper overview of the current situation. Is there any change in terms of broader compatibility to be expected in the near future ? My actual question...what kind of benefits could the user expect vs the potential downsides of keeping 2 versions (XML only as GitHub release) going for the time being ? |
Mostly generating the xml icons is much faster then the png when generating the release also the file size is much smaller. Generating all 8000 icons for the you version takes on my pc arround 20 seconds for the png it takes for just a few icons over a minute. I just prepared the xml functionality with these changes mostly this change is for the use of the android studio built in converter for the you Version. |
The filesize plays into my thought on a recent Issue involving people using more than 1 Arcticon Version and the 3 Files in 1 Release situation here on GitHub. (regarding Obtainium - #1814) While I suggested a couple Workarounds that can work, you would still be in a bit of a mismatch depending on the starting point. The end solution here obviously has the goal of least disruption possible. Given that You is RB allowing for free source selection, how about a potential introduction/transition to an XML version hosted by Izzy. Would drop the version mismatch and manual work completely, no issues with filesize limits either. Lots of thoughts on things I have absolutely no say in of course, but in the name of 'open', 'coverage' and 'convenience' and "partially impacted" user myself...might as well be the voice of the at least two other users out there that would like to move further away from whatever the f*ck Google is doing with the Play Store, in a somewhat streamlined way. F-Droid can, could and maybe should be seen as already existing solution, that's why I mention it here again. (Just a thought dump and not meant to mess with the goal of your PR) |
i don,t even think that xml icons will make any problems on any launcher because the drawables are handled by android it self in most cases. |
lemme know for beta testing happy to help in free time! |
Might as well link the initial test round here #1832 |
Probably gonna postpone this till MS Launcher gets their shit together |
In other words the day they end support for it. Will Arcticons still be around then ? Given that plenty of (older) Launcher support it without there being that much demand currently, it doesn't appear to be all that difficult unless you actively want to make it not work. Without inside look on the actual goal of what the launcher is supposed to be/stand for, I can't really picture any obvious reason for actively not supporting it. Obviously nothing new when it comes to decisions made by big companies. |
better to create new dev branch soo new variant SVG → XML keep updating during Christmas time. AS Microsoft Being Microsoft they only change when required.... |
Convert Svgs at build time to xml drawables with android studios built in converter
add xml icon support for light and dark(disabled for now)
fix clock color in light
move some drawables (drawables that aren't icons are now all in one place /drawables for each version)