fix: false positive recent votes tests #1166
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tegrate-username-functionality
…ArdentHQ/arkscan into feat/reintegrate-username-functionality
…tegrate-username-functionality
…tegrate-username-functionality
alexbarnsley
changed the base branch from
mainsail-develop
to
feat/reintegrate-username-functionality
Base automatically changed from
feat/reintegrate-username-functionality
to
mainsail-develop
January 22, 2025 16:23
…-positive-recent-votes-tests
alexbarnsley
commented
Jan 24, 2025
| ]); | ||
| }); | ||
|
|
||
| it('should sort name in ascending order', function () { |
There was a problem hiding this comment.
There's a new test so these were no longer needed
alexbarnsley
requested review from
boldninja,
ItsANameToo and
samharperpittam
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Noticed when working on #1101 (https://app.clickup.com/t/86dvdmpme)
The tests were looking for an address associated with a transaction (e.g.
$voteTransaction->address) which returnednull. This was allowing the LivewireassertSeeInOrderchecks to think it was passing since it must just skip over null checks.Requires #1101 to be merged first
Checklist