-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update overlay styles when switching address #180
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed extra spaces: 5a45a4e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
won't this affect other pages as well? 🤔 in the design we have a slight visual of the background, but with this change you won't see that anymore on those pages. E.g. compare the following:
I think we should instead look for the reason why the gallery page is lacking the backdrop in the outlined scenario as opposed to making this general adjustment
…/ArdentHQ/dashbrd into fix/address-switching-break-page
@ItsANameToo fixed this issue with the following:
The problem I noticed was that when we changed our wallets, the
Let me know what you think, for now, will move this ticket back to |
Video of the solution being implemented: Screen.Recording.2023-10-05.at.08.23.31.mov |
…dentHQ/dashbrd into refactor/replace-axios-cancel
…on's spam contract existence (#185)
f5eb48e
to
9c50c93
Compare
[Galleries] Address Switching can break page
Summary
Overlay
component have been updated to match the design here.Steps to reproduce
local
mode.php artisan horizon
running.Publish
, change your wallet in Metamask to one without NFTs and see the magic ✨Checklist