Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: ignore markdown on metadata #287

Merged
merged 9 commits into from
Oct 30, 2023

Conversation

alfonsobries
Copy link
Contributor

Summary

note article observer and markdown parsing is based on #272

Closes https://app.clickup.com/t/862kh4tf2

Checklist

  • I checked my UI changes against the design and there are no notable differences
  • I checked my UI changes for any responsiveness issues
  • I checked my (code) changes for obvious issues, debug statements and commented code
  • I opened a corresponding card on Clickup for any remaining TODOs in my code
  • I added a short description on how to test this PR (if necessary)
  • I added a storybook entry for the component that was added (if necessary)
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ItsANameToo
Copy link
Contributor

draft until #272 is merged

@ItsANameToo ItsANameToo marked this pull request as draft October 26, 2023 10:00
@ItsANameToo ItsANameToo added this to the 0.10.0 milestone Oct 26, 2023
@ItsANameToo
Copy link
Contributor

conflicts now that #272 is merged @alfonsobries

@alfonsobries
Copy link
Contributor Author

@ItsANameToo

@alfonsobries alfonsobries marked this pull request as ready for review October 27, 2023 13:45
@ItsANameToo ItsANameToo merged commit b81f0b0 into feat/articles Oct 30, 2023
17 of 18 checks passed
@ItsANameToo ItsANameToo deleted the refactor/ignore-markdown-on-metadata branch October 30, 2023 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants