Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: test warnings #345

Merged
merged 12 commits into from
Nov 2, 2023
Merged

fix: test warnings #345

merged 12 commits into from
Nov 2, 2023

Conversation

patricio0312rev
Copy link
Contributor

@patricio0312rev patricio0312rev commented Nov 2, 2023

[tests] fix test warnings

Summary

  • render method in Report test case has been wrapped in act util to fix warnings.
  • These warnings were related to headless-ui implementations in our Report component.
  • After trying different ideas from multiple sources, this one seemed to be the one that worked perfectly.

Screenshots

  • Warnings before this fix:
image
  • Warnings after this fix (none):
image

Steps to reproduce

  1. Run the app tests by using pnpm test and see the magic ✨

Checklist

  • I checked my UI changes against the design and there are no notable differences
  • I checked my UI changes for any responsiveness issues
  • I checked my (code) changes for obvious issues, debug statements and commented code
  • I opened a corresponding card on Clickup for any remaining TODOs in my code
  • I added a short description on how to test this PR (if necessary)
  • I added a storybook entry for the component that was added (if necessary)
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@github-actions github-actions bot added the bugfix label Nov 2, 2023
@patricio0312rev patricio0312rev marked this pull request as ready for review November 2, 2023 14:44
@ItsANameToo ItsANameToo added this to the 0.11.0 milestone Nov 2, 2023
@ItsANameToo ItsANameToo merged commit b7ec619 into develop Nov 2, 2023
14 checks passed
@ItsANameToo ItsANameToo deleted the fix/unit-test-warnings branch November 2, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants