Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: test warnings #345

Merged
merged 12 commits into from
Nov 2, 2023
Merged

fix: test warnings #345

Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
8299511
fix: wrap report unit case in act util
patricio0312rev Nov 2, 2023
d229bb5
wip
patricio0312rev Nov 2, 2023
348f9c6
style: resolve linting violations
patricio0312rev Nov 2, 2023
7c270d7
wip
patricio0312rev Nov 2, 2023
9ef02d6
fix: make test async and wrap it in act util from testing libraryg
patricio0312rev Nov 2, 2023
a0fce9d
fix: remove await from render method
patricio0312rev Nov 2, 2023
ec779ba
wip
patricio0312rev Nov 2, 2023
2482c17
wip
patricio0312rev Nov 2, 2023
2f3d7de
style: resolve style guide violations
patricio0312rev Nov 2, 2023
7ba4abd
wip
patricio0312rev Nov 2, 2023
07b5d52
refactor: wrap render method correctly
patricio0312rev Nov 2, 2023
40bab77
Merge branch 'fix/unit-test-warnings' of https://github.com/ArdentHQ/…
patricio0312rev Nov 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions resources/js/Components/Report.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import NftFactory from "@/Tests/Factories/Nfts/NftFactory";
import UserDataFactory from "@/Tests/Factories/UserDataFactory";
import WalletFactory from "@/Tests/Factories/Wallet/WalletFactory";
import { getSampleMetaMaskState } from "@/Tests/SampleData/SampleMetaMaskState";
import { mockAuthContext, render, screen, userEvent } from "@/Tests/testing-library";
import { act, mockAuthContext, render, screen, userEvent } from "@/Tests/testing-library";

let routerSpy: SpyInstance;
let useAuthorizedActionSpy: SpyInstance;
Expand Down Expand Up @@ -129,15 +129,17 @@ describe("Report", () => {
expect(screen.queryByTestId("ReportModal")).not.toBeInTheDocument();
});

it("show report modal on load", () => {
it("show report modal on load", async () => {
const collection = new CollectionDetailDataFactory().create();

render(
<Report
model={collection}
modelType={"collection"}
show={true}
/>,
await act(() =>
render(
<Report
model={collection}
modelType={"collection"}
show={true}
/>,
),
);

expect(screen.getByTestId("ReportModal")).toBeInTheDocument();
Expand Down
Loading