-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: adjust collection carousel ui #505
refactor: adjust collection carousel ui #505
Conversation
9a54c6d
to
80b66fc
Compare
…der' into feat/collection-slider
…into feat/collection-slider
resources/js/Pages/Collections/Components/FeaturedCollections/FeaturedCollectionsItem.tsx
Show resolved
Hide resolved
resources/js/Pages/Collections/Components/FeaturedCollections/FeaturedCollectionsItem.tsx
Show resolved
Hide resolved
…into feat/collection-slider
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maaan, this PR is amazing 🔥
The only difference I found with what we currently have is that the user is no longer able to manually move the slides infinitely, as we can see in the video.
Screen.Recording.2023-11-27.at.11.59.32.mov
I don't consider this as a big issue, since we can also click on the pagination 🌟
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
other than the animation of the pagination being discussed pr looks good
Summary
Depends on #494
Closes https://app.clickup.com/t/86dqk29xp
Checklist