Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: adjust collection carousel ui #505

Merged
merged 18 commits into from
Nov 27, 2023

Conversation

goga-m
Copy link
Contributor

@goga-m goga-m commented Nov 24, 2023

Summary

Depends on #494
Closes https://app.clickup.com/t/86dqk29xp

  • Adds carousel pagination (bars)
  • Autoplay is on by default
  • The active pagination bar shows the remaining time until next slide.

Checklist

  • I checked my UI changes against the design and there are no notable differences
  • I checked my UI changes for any responsiveness issues
  • I checked my (code) changes for obvious issues, debug statements and commented code
  • I opened a corresponding card on Clickup for any remaining TODOs in my code
  • I added a short description on how to test this PR (if necessary)
  • I added a storybook entry for the component that was added (if necessary)
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ItsANameToo ItsANameToo added this to the TBD milestone Nov 24, 2023
@goga-m goga-m force-pushed the feat/collection-slider branch from 9a54c6d to 80b66fc Compare November 27, 2023 11:24
@goga-m goga-m marked this pull request as ready for review November 27, 2023 16:29
Copy link
Contributor

@patricio0312rev patricio0312rev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maaan, this PR is amazing 🔥

The only difference I found with what we currently have is that the user is no longer able to manually move the slides infinitely, as we can see in the video.

Screen.Recording.2023-11-27.at.11.59.32.mov

I don't consider this as a big issue, since we can also click on the pagination 🌟

Copy link
Contributor

@alfonsobries alfonsobries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other than the animation of the pagination being discussed pr looks good

@ItsANameToo ItsANameToo merged commit 9bae5c1 into feat/collections-overview Nov 27, 2023
16 checks passed
@ItsANameToo ItsANameToo deleted the feat/collection-slider branch November 27, 2023 18:47
@ItsANameToo ItsANameToo modified the milestones: TBD, 0.13.0 Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants