Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Alchemy API v3 migration #516

Merged
merged 7 commits into from
Nov 30, 2023
Merged

refactor: Alchemy API v3 migration #516

merged 7 commits into from
Nov 30, 2023

Conversation

shahin-hq
Copy link
Contributor

@shahin-hq shahin-hq commented Nov 28, 2023 •
edited
Loading

Summary

Closes: https://app.clickup.com/t/86dqj93x2 and all of its subtasks

Checklist

  • I checked my UI changes against the design and there are no notable differences
  • I checked my UI changes for any responsiveness issues
  • I checked my (code) changes for obvious issues, debug statements and commented code
  • I opened a corresponding card on Clickup for any remaining TODOs in my code
  • I added a short description on how to test this PR (if necessary)
  • I added a storybook entry for the component that was added (if necessary)
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@shahin-hq shahin-hq changed the title feat: Alchemy API v3 migration refactor: Alchemy API v3 migration Nov 28, 2023
@github-actions github-actions bot added refactor and removed feature labels Nov 28, 2023
@shahin-hq shahin-hq marked this pull request as ready for review November 28, 2023 13:10
patricio0312rev
patricio0312rev approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@patricio0312rev patricio0312rev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM! 🔥
Amazing job 🚀

@ItsANameToo ItsANameToo merged commit da50b42 into develop Nov 30, 2023
12 checks passed
@ItsANameToo ItsANameToo deleted the feat/alchemy-v3 branch November 30, 2023 10:21
@ItsANameToo ItsANameToo added this to the 0.12.0 milestone Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oXtxNt9U oXtxNt9U oXtxNt9U approved these changes

@patricio0312rev patricio0312rev patricio0312rev approved these changes

@ItsANameToo ItsANameToo ItsANameToo approved these changes

@samharperpittam samharperpittam Awaiting requested review from samharperpittam samharperpittam is a code owner

@boldninja boldninja Awaiting requested review from boldninja boldninja is a code owner

Assignees

@alfonsobries alfonsobries

@ItsANameToo ItsANameToo

@patricio0312rev patricio0312rev

Labels
refactor
Projects
None yet
Milestone
0.12.0
Development

Successfully merging this pull request may close these issues.
5 participants
@shahin-hq @ItsANameToo @patricio0312rev @oXtxNt9U @alfonsobries