-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add popular collections table #552
feat: add popular collections table #552
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trying to access this page as a guest results in 500 error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you link to this page from "View all" link of "Popular Collections" on the /collections
?
Please include all active filters when navigating with pagination.
Also, can you disable sorting on the table? Right now it seems as if you can click the headings to sort, but we aren't doing that for now.
@samharperpittam should be good now, please check |
Should be good, please give a try |
Pagination doesn't work but is fixed in the following PR: #555 |
Summary
Closes: https://app.clickup.com/t/86dqnpmtg
This PR:
Hit http://127.0.0.1:8000/popular-collections to see the page
Checklist