Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add popular collections table #552

Merged
merged 20 commits into from
Dec 12, 2023

Conversation

shahin-hq
Copy link
Contributor

@shahin-hq shahin-hq commented Dec 11, 2023

Summary

Closes: https://app.clickup.com/t/86dqnpmtg

This PR:

  • adds the popular collections table
  • adds pagination components
  • adds filter components and logic (I am planning to extract filter logic into a hook so we can share it between collections overview and popular collections page)
  • hooks up real data for the some parts of page

Hit http://127.0.0.1:8000/popular-collections to see the page

Checklist

  • I checked my UI changes against the design and there are no notable differences
  • I checked my UI changes for any responsiveness issues
  • I checked my (code) changes for obvious issues, debug statements and commented code
  • I opened a corresponding card on Clickup for any remaining TODOs in my code
  • I added a short description on how to test this PR (if necessary)
  • I added a storybook entry for the component that was added (if necessary)
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ItsANameToo ItsANameToo added this to the 0.13.0 milestone Dec 12, 2023
@shahin-hq shahin-hq marked this pull request as ready for review December 12, 2023 10:29
Copy link

@samharperpittam samharperpittam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trying to access this page as a guest results in 500 error.

@samharperpittam samharperpittam marked this pull request as draft December 12, 2023 13:24
Copy link
Contributor

@crnkovic crnkovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you link to this page from "View all" link of "Popular Collections" on the /collections?

Please include all active filters when navigating with pagination.

Also, can you disable sorting on the table? Right now it seems as if you can click the headings to sort, but we aren't doing that for now.

@crnkovic crnkovic self-assigned this Dec 12, 2023
@shahin-hq
Copy link
Contributor Author

@samharperpittam should be good now, please check

@shahin-hq
Copy link
Contributor Author

Can you link to this page from "View all" link of "Popular Collections" on the /collections?
Please include all active filters when navigating with pagination.
Also, can you disable sorting on the table? Right now it seems as if you can click the headings to sort, but we aren't doing that for now.

Should be good, please give a try

@shahin-hq shahin-hq requested a review from crnkovic December 12, 2023 14:13
@shahin-hq shahin-hq marked this pull request as ready for review December 12, 2023 14:16
@crnkovic
Copy link
Contributor

Pagination doesn't work but is fixed in the following PR: #555

@crnkovic crnkovic merged commit c1da7b3 into feat/collections-overview Dec 12, 2023
16 checks passed
@crnkovic crnkovic deleted the feat/popular-collections-table branch December 12, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants