Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add popular collections search #555

Merged
merged 42 commits into from
Dec 13, 2023

Conversation

shahin-hq
Copy link
Contributor

@shahin-hq shahin-hq commented Dec 12, 2023

Summary

Depends on #552

Closes: https://app.clickup.com/t/86dqpda6z

  • adds search
  • fixes minor issue with pagination
  • fixes nominate collection name search bug

Checklist

  • I checked my UI changes against the design and there are no notable differences
  • I checked my UI changes for any responsiveness issues
  • I checked my (code) changes for obvious issues, debug statements and commented code
  • I opened a corresponding card on Clickup for any remaining TODOs in my code
  • I added a short description on how to test this PR (if necessary)
  • I added a storybook entry for the component that was added (if necessary)
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@shahin-hq shahin-hq marked this pull request as ready for review December 12, 2023 15:31
Base automatically changed from feat/popular-collections-table to feat/collections-overview December 12, 2023 15:41
…s-search

# Conflicts:
#	app/Http/Controllers/PopularCollectionController.php
#	resources/js/Pages/Collections/Components/PopularCollections/CollectionsFullTablePagination.tsx
#	resources/js/Pages/Collections/Index.tsx
#	resources/js/Pages/Collections/PopularCollections/Index.tsx
@crnkovic crnkovic self-assigned this Dec 13, 2023
@crnkovic crnkovic mentioned this pull request Dec 13, 2023
9 tasks
Copy link
Contributor

@crnkovic crnkovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you tackled pagination in this PR, can you also take care of changing the per-page items in this PR? Changing them still does nothing. On that note, I have created a task to fix the bug where next/prev/first/last buttons in the pagination are not applying the query strings.


Search looks good, just expand the width a bit so the text fits. Also, can you make it preserve the state so it doesn't lose input focus after searching?

Screenshot 2023-12-13 at 09 59 25

Note for @samharperpittam: currently, there are no filters on mobile, so I have created a card to add them to this page.


Looks like the table headers are missing when there are no results:

Screenshot 2023-12-13 at 10 03 04

Design:
Screenshot 2023-12-13 at 10 02 42

@crnkovic crnkovic marked this pull request as draft December 13, 2023 09:05
@ItsANameToo ItsANameToo added this to the 0.13.0 milestone Dec 13, 2023
@shahin-hq
Copy link
Contributor Author

shahin-hq commented Dec 13, 2023

@crnkovic

I have created a task to fix the bug where next/prev/first/last buttons in the pagination are not applying the query strings.

one line, fixed it

Search looks good, just expand the width a bit so the text fits. Also, can you make it preserve the state so it doesn't lose input focus after searching?

fixed

Looks like the table headers are missing when there are no results:

fixed

can you also take care of changing the per-page items in this PR?

I already handled it in the next PR, didn't want to overload this one too much, I can move my changes here if you really want to

@shahin-hq shahin-hq marked this pull request as ready for review December 13, 2023 10:20
@shahin-hq shahin-hq requested a review from crnkovic December 13, 2023 10:20
@shahin-hq shahin-hq mentioned this pull request Dec 13, 2023
9 tasks
@shahin-hq shahin-hq merged commit 9973e49 into feat/collections-overview Dec 13, 2023
16 checks passed
@shahin-hq shahin-hq deleted the feat/popular-collections-search branch December 13, 2023 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants