-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add popular collections search #555
feat: add popular collections search #555
Conversation
…s-search # Conflicts: # app/Http/Controllers/PopularCollectionController.php # resources/js/Pages/Collections/Components/PopularCollections/CollectionsFullTablePagination.tsx # resources/js/Pages/Collections/Index.tsx # resources/js/Pages/Collections/PopularCollections/Index.tsx
… into feat/popular-collections-search
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since you tackled pagination in this PR, can you also take care of changing the per-page items in this PR? Changing them still does nothing. On that note, I have created a task to fix the bug where next/prev/first/last buttons in the pagination are not applying the query strings.
Search looks good, just expand the width a bit so the text fits. Also, can you make it preserve the state so it doesn't lose input focus after searching?
Note for @samharperpittam: currently, there are no filters on mobile, so I have created a card to add them to this page.
Looks like the table headers are missing when there are no results:
one line, fixed it
fixed
fixed
I already handled it in the next PR, didn't want to overload this one too much, I can move my changes here if you really want to |
Summary
Depends on #552
Closes: https://app.clickup.com/t/86dqpda6z
Checklist