Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: sorting by volume change in a specific period #607

Merged
merged 22 commits into from
Jan 19, 2024

Conversation

crnkovic
Copy link
Contributor

@crnkovic crnkovic commented Jan 18, 2024

Summary

https://app.clickup.com/t/86dr7u6x3

Built from #576 as we use the columns from that PR

Keep in mind that the table will still show the volume column and not the volume in the specific period (avg_volume_7d, etc), so it may appear that sorting is not working as volume columns won't be alright, but that's a part of another task. But you can open the database GUI, manually order by any of those values and check that it properly sorts.

As a part of this PR, I added orderByWithNulls scope to the Collection model. We've been repeating the same logic of ordering NULL values first in ASC order, and last in DESC order, so I created a scope for allow some code reuse.

Checklist

  • I checked my UI changes against the design and there are no notable differences
  • I checked my UI changes for any responsiveness issues
  • I checked my (code) changes for obvious issues, debug statements and commented code
  • I opened a corresponding card on Clickup for any remaining TODOs in my code
  • I added a short description on how to test this PR (if necessary)
  • I added a storybook entry for the component that was added (if necessary)
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@crnkovic crnkovic marked this pull request as ready for review January 18, 2024 12:37
@crnkovic crnkovic marked this pull request as draft January 18, 2024 14:49
@crnkovic crnkovic marked this pull request as ready for review January 18, 2024 14:52
@ItsANameToo ItsANameToo merged commit 06b3702 into develop Jan 19, 2024
17 of 18 checks passed
@ItsANameToo ItsANameToo deleted the refactor/sorting-by-volume branch January 19, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants