-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: sorting by volume change in a specific period #607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samharperpittam
approved these changes
Jan 18, 2024
9 tasks
ItsANameToo
approved these changes
Jan 19, 2024
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
https://app.clickup.com/t/86dr7u6x3
Built from #576 as we use the columns from that PR
Keep in mind that the table will still show the
volume
column and not the volume in the specific period (avg_volume_7d
, etc), so it may appear that sorting is not working as volume columns won't be alright, but that's a part of another task. But you can open the database GUI, manually order by any of those values and check that it properly sorts.As a part of this PR, I added
orderByWithNulls
scope to the Collection model. We've been repeating the same logic of ordering NULL values first in ASC order, and last in DESC order, so I created a scope for allow some code reuse.Checklist