refactor: sort popular collections by volume #612

crnkovic · 2024-01-19T12:45:36Z

Summary

Same treatment as #607, but for /collections/popular page, though we don't show the volume in the table.

I checked my UI changes against the design and there are no notable differences
I checked my UI changes for any responsiveness issues
I checked my (code) changes for obvious issues, debug statements and commented code
I opened a corresponding card on Clickup for any remaining TODOs in my code
I added a short description on how to test this PR (if necessary)
I added a storybook entry for the component that was added (if necessary)
Documentation (if necessary)
Tests (if necessary)
Ready to be merged

ItsANameToo · 2024-01-22T12:10:47Z

Update PopularCollectionController.php

a8ff042

crnkovic requested review from samharperpittam and boldninja as code owners January 19, 2024 12:45

github-actions bot added the refactor label Jan 19, 2024

samharperpittam approved these changes Jan 19, 2024

View reviewed changes

crnkovic marked this pull request as draft January 19, 2024 13:33

crnkovic added 2 commits January 19, 2024 14:35

wip

c6a43ba

Update Collection.php

6b239ee

crnkovic marked this pull request as ready for review January 19, 2024 13:47

crnkovic requested a review from samharperpittam January 19, 2024 15:15

crnkovic and others added 2 commits January 19, 2024 17:00

wip

876937d

style: resolve style guide violations

a9163c2

samharperpittam approved these changes Jan 22, 2024

View reviewed changes

Merge branch 'develop' into refactor/sort-popular-collections

bd0f62e

crnkovic requested a review from samharperpittam January 22, 2024 10:11

ItsANameToo approved these changes Jan 22, 2024

View reviewed changes

ItsANameToo merged commit d0044a8 into develop Jan 22, 2024
12 checks passed

ItsANameToo deleted the refactor/sort-popular-collections branch January 22, 2024 12:07