AP_Scripting: use helper for not supported error saving 1K of flash #16644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WickedShell
suggested changes
Feb 17, 2021
IamPete1
force-pushed
the
scr_flash_helper
branch
from
d1d25f4 to
9001f0c
Compare
WickedShell
approved these changes
Feb 18, 2021
|
Was this actually tested on real hardware/sitl somewhere? The normal autotests won't test this for us. |
|
Yeah, tested in SITL with |
|
Great, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make up for #13753 this adds a helper function that saves ~1K (1080) of flash. This is due to cutting down the length of similar strings. I did also try the same with the
%s out of rangestring but that is not a net saving (I guess due to the way the compiler merges constants or something?).