Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Add Phoenix Llamaindex RAG Demo notebook + chunks + questions #4202

Merged
merged 18 commits into from
Aug 17, 2024
Merged

docs: Add Phoenix Llamaindex RAG Demo notebook + chunks + questions #4202

merged 18 commits into from
Aug 17, 2024

Conversation

saikolasani
Copy link
Contributor

@saikolasani saikolasani commented Aug 9, 2024 •
edited by mikeldking
Loading

resolves #4004

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Aug 9, 2024
@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@saikolasani saikolasani changed the title Add Phoenix Llamaindex RAG Demo notebook + chunks + questions docs: Add Phoenix Llamaindex RAG Demo notebook + chunks + questions Aug 9, 2024
@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Aug 12, 2024
@mikeldking
Copy link
Contributor

nit: can we rename to demo_llama_index just to keep track of demo data creation notebooks?

mikeldking
mikeldking reviewed Aug 13, 2024
View reviewed changes
Copy link
Contributor

@mikeldking mikeldking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is pretty close to just merging. Let's remove the artifacts of the chunking for now

@cjunkin
Copy link
Contributor

cjunkin commented Aug 14, 2024

resolves #4240

@cjunkin
Copy link
Contributor

cjunkin commented Aug 14, 2024

Cohesive use case questions fixture: https://console.cloud.google.com/storage/browser/arize-phoenix-assets/demos?pageState=(%22StorageObjectListTable%22:(%22f%22:%22%255B%255D%22))&project=phoenix-202055

RAG demo traces and evals (demo_llama_index_rag_): https://console.cloud.google.com/storage/browser/arize-phoenix-assets/traces?pageState=(%22StorageObjectListTable%22:(%22f%22:%22%255B%255D%22))&project=phoenix-202055

mikeldking
mikeldking approved these changes Aug 16, 2024
View reviewed changes
.gitignore Show resolved Hide resolved
src/phoenix/trace/fixtures.py Outdated Show resolved Hide resolved
src/phoenix/trace/fixtures.py Outdated Show resolved Hide resolved
src/phoenix/trace/fixtures.py Outdated Show resolved Hide resolved
src/phoenix/trace/fixtures.py Show resolved Hide resolved
@cjunkin
Copy link
Contributor

cjunkin commented Aug 16, 2024

Demo traces available on hosted phoenix

image

@cjunkin
Copy link
Contributor

cjunkin commented Aug 16, 2024 •
edited
Loading

However, seems like document relevance eval fixtures have some formatting problems. This isn't an issue with the code, however, and seems to be how the doc relevance eval spans were generated. Seems like rerunning the demo and uploading new fixtures to GCS would fix the issue. Merging PR
image

@cjunkin cjunkin merged commit 7f1b817 into main Aug 17, 2024
11 checks passed
@cjunkin cjunkin deleted the sai/phoenixllRAG branch August 17, 2024 00:30
@mikeldking mikeldking mentioned this pull request Aug 19, 2024
Merged
@cjunkin cjunkin mentioned this pull request Aug 20, 2024
Merged
fjcasti1 added a commit that referenced this pull request Aug 20, 2024
@fjcasti1
Merge branch 'main' into demo_llama_index
2caf17a 
* main:
  chore: add utility function for password salting and hashing (#4287)
  chore: update ruff to 0.6.1 (#4282)
  chore(main): release arize-phoenix-otel 0.2.0 (#4281)
  feat: Clarify `register` API documentation (#4280)
  README patch (#4279)
  refactor(auth): name it role.name (#4265)
  docs: add haystack to README
  docs: Add Phoenix Llamaindex RAG Demo notebook + chunks + questions (#4202)
  chore(main): release arize-phoenix-otel 0.1.0 (#4264)
  feat: Create `phoenix.otel` package (#4230)
  fix: conditionally display re-ranker queries in span details (#4263)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjunkin cjunkin cjunkin left review comments

@mikeldking mikeldking mikeldking approved these changes

Assignees
No one assigned
Labels
size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[onboarding] cohesive demo data
3 participants
@saikolasani @mikeldking @cjunkin