refactor(auth): name it role.name #4265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:M
mikeldking
commented
Aug 17, 2024
| @@ -92,7 +92,8 @@ async def users( | |||
| ) | |||
| stmt = ( | |||
| select(models.User) | |||
| .where(models.UserRole.role != "SYSTEM") | |||
| .join(models.UserRole) | |||
There was a problem hiding this comment.
I do need to perform this join. It otherwise does not work.
fjcasti1
added a commit
that referenced
this pull request
Aug 20, 2024
* main: chore: add utility function for password salting and hashing (#4287) chore: update ruff to 0.6.1 (#4282) chore(main): release arize-phoenix-otel 0.2.0 (#4281) feat: Clarify `register` API documentation (#4280) README patch (#4279) refactor(auth): name it role.name (#4265) docs: add haystack to README docs: Add Phoenix Llamaindex RAG Demo notebook + chunks + questions (#4202) chore(main): release arize-phoenix-otel 0.1.0 (#4264) feat: Create `phoenix.otel` package (#4230) fix: conditionally display re-ranker queries in span details (#4263)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
role.name is more intuitive