upgrade LabeledSpanLengthCollector to SpanLengthCollector
#352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s optional and inferrable, add tokenization capability
ArneBinder
force-pushed
the
span_length_collector
branch
from
7ef15d7 to
ad4797e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades
LabeledSpanLengthCollectortoSpanLengthCollector:IMPORTANT NOTE (similar to #351): Inferring labels produces wrong results for certain
aggregation_functionssuch asmin,mean, andstdbecause documents with zero entries of a certain label are not considered anymore for that label. We remove these fromaggregation_functionsiflabels == "INFERRED", but we can not handle any user defined function (which relies on correct zero values).