Fix for Marking Database for Delete in Perforce #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brwarner
added a commit
that referenced
this pull request
Aug 21, 2021
* Updated to latest UE API for UE 4.27 and UE 5 * Fixed preprocessor directives for UE 5 * Fixed script method string return type * Update ArticyImportData.cpp Fixed a Bug where <id>.<id> string patterns were replaced by an GV access even if that pattern occured within a literal string. * UE5 Support (#41) * Update README.md Added info for UE 5 * Fixed missing articy toolbar buttons. They now live in the Settings menu. * Removed note about broken UI from Readme * Guarding UE5 changes with #if's * Updating Readme so it applies to both UE4 and 5 * Fixing registration order Co-authored-by: Peter Sabath <31621424+peter-sabath@users.noreply.github.com> * Use CheckoutPackages and SavePackages instead of PromptForCheckoutAndSave (#42) * Updating Changelog Co-authored-by: Christian Schildt <38693641+christian-schildt@users.noreply.github.com> Co-authored-by: Peter Sabath <31621424+peter-sabath@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug for Perforce users where triggering a rebuild of the generated Articy code would mark your package and database assets for "Delete" in Perforce despite the fact they'd been regenerated. They are now correctly checked out for edit instead.
Tested in Unreal 4.26. Builds in Unreal 5.