Update macOS scripts and support multiple types of GPA (new) #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. Made function for toggling between weighted, unweighted, and % GPA (only works for current quarter right now... Also, There is a bu where if you select another quarter you cannot return to the initial quarter and have it work properly...).
Apparently kdk1616's editor completely changed the formatting of the README. As there were no substantial changes, I have reverted all changes that were made to the README.
…riable for current term
There is a function in extraFunctions.js to convert a percentage to a GPA out of 4.0; the inline code duplicating that behavior has been replaced by a function call.
This is a minor change, as the currently selected term is the same as the current term when Aspine is first loading, but it aids code readability for the refactoring to come.
Abstracting away the iterator reduces the potential for errors and simplifies the code.
The GPA and calcGPA attributes of each term's object under tableData are now themselves objects with attributes "percent", "outOfFour", and "outOfFive". This approach is more scalable and also allows all GPAs to be returned by a single function, computeGPA, which has been modified to compute all three formats of GPA.
The current quarter need not be hardcoded anymore. Also, the refactored GPAType uses jQuery and is more readable.
Because the selection of the <select> element is a string and it is being compared to the number zero, I have changed triple equals to double equals in order to invoke type coercion.
psvenk
changed the title
psvenk
force-pushed
the
master
branch
3 times, most recently
from
2c334f3 to
e6a8705
Compare
psvenk
changed the title
psvenk
changed the title
psvenk
force-pushed
the
master
branch
3 times, most recently
from
49458de to
5a79cb1
Compare
psvenk
changed the title
psvenk
changed the title
Instead of taking `type` as a parameter and giving a different value depending on the type, cumGPA() now returns an object containing all GPA types.
The "GPA Type" button now controls the GPA type of all terms in the dropdown instead of only the selected one, and the term can be changed while a non-percent GPA type is selected.
This makes the UI work more intuitively and allows the term dropdown to resize horizontally as needed.
Fix a bug in which fetching a new term would overwrite the current term data
Ruborcalor
reviewed
Mar 16, 2020
Fix some bugs that would be encountered if a user modifies some assignments, thus generating a calculated GPA, in any one of the non-percent GPA types.
|
I have addressed every issue that I have identified, except for redesigning the cumulative GPA indicator so that it updates along with the quarters in showing percent, unweighted, or weighted instead of just showing all three always. It would also be nice to have a calculated cumulative GPA which uses calcGPA for each quarter (falling back to GPA if needed). |
Instead of having a rich-text presentation of the cumulative GPA showing all GPA types at once, make it cycle through the GPA types along with the quarters (current, Q1, Q2, Q3, Q4).
|
I approve! |
This was referenced Mar 18, 2020
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains two features.