Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored package.json (new) #106

Merged
merged 5 commits into from
Mar 18, 2020
Merged

Refactored package.json (new) #106

merged 5 commits into from
Mar 18, 2020

Conversation

psvenk
Copy link
Member

@psvenk psvenk commented Mar 17, 2020

This is the replacement for @notrodes' original pull request #93. For some reason, he deleted his fork of the repository, so I had to create a branch on this repository and initiate a pull request from the new branch.

Original description:

in accordance with npm docs (here). Moved lines, changed from author field to contributors field. Updated repository.

now server can be started with npm start

notrodes and others added 5 commits March 17, 2020 15:22
…e don't know where) and `node FILENAME` will always succeed. In serve.js removed unused dependencies, useless socket code and unused constants. Terminated lines and declared variables explicitly.
Instead of dispensing with the shebang lines entirely, add a shebang
which will work on (almost) all systems,
courtesy of <https://unix.stackexchange.com/a/65295>.
Due to node sandboxing, serve.js is not permitted to access
"../public/home.html", so I have moved serve.js and scrape.js back to
the root of the repository so that they are able to see the entire
repository.
@psvenk
Copy link
Member Author

psvenk commented Mar 17, 2020

I think this is ready to merge now. We'll merge it along with #101 and #103 (which are also ready to merge) after the current master has been approved for production.

@psvenk psvenk changed the base branch from master to staging March 18, 2020 00:57
@psvenk psvenk merged commit 4f0b2cd into staging Mar 18, 2020
@psvenk psvenk deleted the notrodes/master branch March 18, 2020 01:07
@psvenk psvenk mentioned this pull request Mar 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants