Unify settings pages components #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eLtMosen
force-pushed
the
unify-settings-components
branch
from
f167143
to
60c4590
Compare
eLtMosen
added a commit
to eLtMosen/asteroid-settings
that referenced
this pull request
May 1, 2023
Goal is to make the use of font and icon size and row heigts consistent over all settings pages. As well as to add a HighlightBar for visual feedback and make all rows clickable like in the settings main list. - Remove PageHeader from Units, Display and Nighstand page - Refactor all display, sound and nightstand value selectors into IntSelector - Refactor nightstand page action button to LabeledActionButton - Refactor all possible instances of switches into LabeledSwitch in Units, Display, Nighstand and Sound page. - Remove margins from flickables so components can use the full screen width for the HighlightBar - Set rowHeight of Dims.h(25) for all clickable rows - Move ListItem component to qml-asteroid for consitency Depends on AsteroidOS/qml-asteroid#37 to add and modify the components. Signed-off-by: Timo Könnecke koennecke@mosushi.de
beroset
approved these changes
May 4, 2023
|
Since this adds three new controls, would it make sense to bump the revision to 1.1? |
eLtMosen
force-pushed
the
unify-settings-components
branch
3 times, most recently
from
c906a26
to
71fbaba
Compare
beroset
approved these changes
May 5, 2023
MagneFire
reviewed
May 6, 2023
MagneFire
approved these changes
May 7, 2023
- Bind onClick property to the parent - Bind forceOn property to parent so the PowerPage can enforce highlight to generate radio button beaviour - Use OutQuad easing so that the highlight is visible very fast after onPressed is registered. else it would not be visible on short presses. Co-authored-by: Ed Beroset <beroset@ieee.org> Signed-off-by: Timo Könnecke koennecke@mosushi.de
…ht and Dims.h(25) rowHeight
- Change hardcoded size definitions to global variables that have a sane defaults and can be altered in the component call - Comment all added property variables and alias Thanks to @beroset for help with the comments Co-authored-by: Ed Beroset <beroset@ieee.org> Signed-off-by: Timo Könnecke koennecke@mosushi.de
- revert receiving of functions through the onClicked property, to sending the signal clicked to the parent Co-authored-by: Darrel Griët <dgriet@gmail.com> Signed-off-by: Timo Könnecke koennecke@mosushi.de
eLtMosen
force-pushed
the
unify-settings-components
branch
from
78662c3
to
e3b0572
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unifiy the layouts of the components used on the settings pages to fixed font and icon size.
Give horizontal spacing/margin within the component so the full width of the screen can be used and must not be limited by margins given in the settings pages.