Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify settings pages components #37

Merged
merged 8 commits into from
May 7, 2023
Merged

Unify settings pages components #37

merged 8 commits into from
May 7, 2023

Commits on May 7, 2023

  1. Move ListItem from asteroid-settings

    @eLtMosen
    eLtMosen committed May 7, 2023
    Configuration menu
    Copy the full SHA
    6f72d1e View commit details
    Browse the repository at this point in the history

  2. Add LabeledActionButton analog to LabeledSwitch

    @eLtMosen
    eLtMosen committed May 7, 2023
    Configuration menu
    Copy the full SHA
    ee5ac19 View commit details
    Browse the repository at this point in the history

  3. Add HighlightBar used in LabeledSwitch, LabeledActionButton and Listitem 

    - Bind onClick property to the parent
- Bind forceOn property to parent so the PowerPage can enforce highlight to generate radio button beaviour
- Use OutQuad easing so that the highlight is visible very fast after onPressed is registered. else it would not be visible on short presses.

Co-authored-by: Ed Beroset <beroset@ieee.org>
Signed-off-by: Timo Könnecke koennecke@mosushi.de
    @eLtMosen @beroset
    eLtMosen and beroset committed May 7, 2023
    Configuration menu
    Copy the full SHA
    3f7e3f3 View commit details
    Browse the repository at this point in the history

  4. Refactor Labeled Switch and IntSelector to fixed Dims.h(20) icon heig… 

    …ht and Dims.h(25) rowHeight
    @eLtMosen
    eLtMosen committed May 7, 2023
    Configuration menu
    Copy the full SHA
    590baea View commit details
    Browse the repository at this point in the history

  5. Update qmldir and resource.qrc with new components

    @eLtMosen
    eLtMosen committed May 7, 2023
    Configuration menu
    Copy the full SHA
    679155d View commit details
    Browse the repository at this point in the history

  6. Expose iconSize, rowMargin and labelFontSize to parent 

    - Change hardcoded size definitions to global variables that have a sane defaults and can be altered in the component call
- Comment all added property variables and alias

Thanks to @beroset for help with the comments

Co-authored-by: Ed Beroset <beroset@ieee.org>
Signed-off-by: Timo Könnecke koennecke@mosushi.de
    @eLtMosen @beroset
    eLtMosen and beroset committed May 7, 2023
    Configuration menu
    Copy the full SHA
    728f16d View commit details
    Browse the repository at this point in the history

  7. Move opacity animation from Nightstand page AsteroidOS/asteroid-setti… 

    …ngs@007f5da
    @eLtMosen
    eLtMosen committed May 7, 2023
    Configuration menu
    Copy the full SHA
    c812681 View commit details
    Browse the repository at this point in the history

  8. Simplify onClicked logic in the HighlightBar 

    - revert receiving of functions through the onClicked property, to sending the signal clicked to the parent

Co-authored-by: Darrel Griët <dgriet@gmail.com>
Signed-off-by: Timo Könnecke koennecke@mosushi.de
    @eLtMosen @MagneFire
    eLtMosen and MagneFire committed May 7, 2023
    Configuration menu
    Copy the full SHA
    e3b0572 View commit details
    Browse the repository at this point in the history