Retrofit http client supplier npe fix #1617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch addresses issue that resulted in NPE if http client supplier was specified in `Call.Factory` builder and concrete http client was not, because `getHttpClient()` method was not invoked while constructing retrofit `Call` instance. New, obviously less error prone approach is that http client supplier gets constructed behind the scenes even if user specifies concrete http client instance at call factory creation time and http client supplier is being used exclusively also by `Call` instance. This way there are no hard references to http client instance dangling around in case some component creates a `Call` instance and never issues `newCall()` on it. Fixes #1616.
|
@slandelle i'm really sorry for my previous non-functioning PR. This one actually works and it's better tested. I've also used snapshot dependency in my app and it works 😅. If you're going to accept this PR, please don't roll new release yet, i've noticed that there are possible timeout issues as well (possibly introduced with retrofit 2.5.0) and i plan to address them in separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch addresses issue that resulted in NPE if http client supplier
was specified in
Call.Factorybuilder and concrete http client was not,because
getHttpClient()method was not invoked while constructingretrofit
Callinstance.New, obviously less error prone approach is that http client supplier
gets constructed behind the scenes even if user specifies concrete http
client instance at call factory creation time and http client supplier
is being used exclusively also by
Callinstance. This way there are nohard references to http client instance dangling around in case some
component creates a
Callinstance and never issuesnewCall()on it.Fixes #1616.