Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CORS header support to nginx locations #225

Closed
ansell opened this issue Jan 3, 2019 · 0 comments · Fixed by #370
Closed

Add CORS header support to nginx locations #225

ansell opened this issue Jan 3, 2019 · 0 comments · Fixed by #370
Labels
enhancement IAD security

Comments

@ansell
Copy link
Contributor

ansell commented Jan 3, 2019

NGINX locations need to have CORS support optionally available for applications to specify origins/verbs/etc. that are allowed to perform cross-site queries. This is being done on an ad hoc manner on some servers currently, which makes it impossible to deploy using Ansible to those servers as it would break core functionality that has been manually added.

If add_header is used inside an NGINX location, the other security headers (HSTS/Referrer-Policy/etc.) which are defined in the enclosing server also need to be reinserted into the location or they are ignored.
@ansell ansell added the security label May 8, 2019
vjrj added a commit to vjrj/ala-install that referenced this issue Feb 13, 2020
@vjrj
Added CORS fragment. Fix for AtlasOfLivingAustralia#225
b7a8bc4
@vjrj vjrj mentioned this issue Feb 13, 2020
Merged
vjrj added a commit to vjrj/ala-install that referenced this issue May 14, 2020
@vjrj
Added CORS fragment. Fix for AtlasOfLivingAustralia#225
3002556
@vjrj vjrj closed this as completed in #370 Jun 5, 2020
vjrj added a commit that referenced this issue Jun 5, 2020
@vjrj
Added CORS fragments to nginx_vhost role (#370)
01e47c6 
* Added CORS fragment. Fix for #225

* Added new var following @ansell review

* Added missing bracket
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement IAD security
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added CORS fragments to nginx_vhost role vjrj/ala-install
1 participant
@ansell