Added CORS fragments to nginx_vhost role #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansell
suggested changes
Feb 27, 2020
ansell
reviewed
Feb 27, 2020
vjrj
commented
Mar 13, 2020
|
Since I pushed this PR we have manually applied (*) and tested in several LA deployments (Tanzania, Guatemala, Royal Gardens Kew demo, Vermont). I think is safe to merge it if you don't have any other comment. Thanks, (*) With people not very comfortable with git, this is quite a difficult task. Yesterday I spend more than an hour (looking my chat, from 15:41 to 17:35) just trying to help someone in slack, to apply this PR, to solve the CORS errors in a LA site. And it's not the first time this happens to me. |
|
Merged after talking with @ansell , thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following this conversation in slack this fix #225.
Tested in a demo site.