Skip to content
This repository has been archived by the owner on Aug 7, 2023. It is now read-only.

Skip non-issues messages returned from CodeClimate #77

Closed
wants to merge 1 commit into from
Closed

Skip non-issues messages returned from CodeClimate #77

wants to merge 1 commit into from

Conversation

a-ali
Copy link

@a-ali a-ali commented Dec 7, 2017

fixes #76

@maxjacobson maxjacobson requested a review from gdiggs December 7, 2017 15:31
@maxjacobson maxjacobson mentioned this pull request Dec 11, 2017
Merged
@maxjacobson
Copy link
Contributor

Thanks for opening this PR. This does look good, but we need to get the tests green. They're red on master, so it's not related to your change. I opened #78 to try and get them green, but ... did not succeed. Will plan to come back to this as soon as we can merge it

@cgalvarez cgalvarez mentioned this pull request Feb 24, 2018
Closed
@cgalvarez
Copy link
Contributor

@a-ali @maxjacobson This PR is outdated. I'm using CodeClimate cli v0.71.1, and now the type is issue, not Issue, so this PR is currently making the linter missing all the issues reported by CodeClimate cli.

@cgalvarez
Copy link
Contributor

A note about the required CodeClimate cli version should be added to the README.md too, because depending on that, this package may malfunction.

This was referenced Feb 24, 2018
Closed
Merged
@inakiabt inakiabt mentioned this pull request Mar 6, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gdiggs gdiggs gdiggs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@a-ali @maxjacobson @cgalvarez @gdiggs