-
Notifications
You must be signed in to change notification settings - Fork 5
Conversation
This subcommand was removed. We have an open issue about it on the repo, and the tests are currently timing out on master, which is blocking an unrelated fix. I'm hopeful this will get the tests green.
2fd2fa0
to
4b289ff
Compare
Sigh. That didn't help make it green. I'm not sure how to debug this 😞. If i could run the tests locally I think I'd be able to, but I'm not sure how to do that. Any thoughts @Arcanemagus ? |
Assuming you can run |
I faced this exact problem previously. @pointlessone had to increase the timeout for the promises in the package tests on the CI environment to 60 seconds here with this PR to get the tests passing in CI. The problem right now is that the CodeClimate cli takes much more time now to finish. I'm having times of ~150s locally right now, so maybe in CI it takes even more.
@maxjacobson Like @Arcanemagus says, you only need to run I've checked that increasing that timeout to 150 seconds (locally), the following error appears:
As this is the same error that #77 reports, after applying its fix locally and rerunning the tests, we get:
It seems that after fixing code with #77 the time the cli takes to finish decreases A LOT, again to 20-30s. The new error is due to new issues reported by the cli. The expected first issue is not such, so we need to change the # spec/fixtures/.rubocop.yml
Layout/SpaceAfterMethodName:
Enabled: false
Layout/SpaceAroundEqualsInParameterDefault:
Enabled: false
Layout/SpaceBeforeBlockBraces:
Enabled: false
Style/Lambda:
Enabled: false # spec/fixtures/.codeclimate.yml
---
engines:
rubocop:
enabled: true
fixme:
enabled: true
structure:
enabled: false
ratings:
paths:
- "**.coffee"
exclude_paths:
- node_modules/**/* Making these changes, the tests pass locally, and so should happen in CI. |
I've created PR #82 which achieves the same as this one, but the CI builds successfully. |
This subcommand was removed. We have an open issue about it on the repo,
and the tests are currently timing out on master, which is blocking an
unrelated fix. I'm hopeful this will get the tests green.
Related to #75