CI, coffeelint and travis #58
Conversation
|
Travis-CI enabled 😉 |
|
You should take a look at https://github.com/atom/ci, there are example CI configurations that do a lot for you, and are great bases to configure further from. |
| "license": "MIT", | ||
| "engines": { | ||
| "atom": ">0.50.0" | ||
| }, | ||
| "dependencies": { | ||
| "atom-package-deps": "^4.0.1", | ||
| "atom-package-deps": "4.0.1", |
There was a problem hiding this comment.
I would highly recommend against this, with GreenKeeper enabled on this repo and tests + CI builds enabled all versions will be tested for you. If one of your allowed versions breaks things you will get a PR telling you so, from there you can either pin the version or fix the thing that is broken.
If you pin it like this though you will get a PR for every single update, since it will be outside your allowed range.
There was a problem hiding this comment.
@Arcanemagus Let me explain some use case:
For example, the atom-package-deps has been updated to v4.1.0. v4.1.0 satisfies ^4.0.1 and breaks something. So until I am not fixed changes or pinned the version, all new linter-tslint users can get an error. From this point of view - strict versioning is the most stable variant.
There was a problem hiding this comment.
Greenkeeper will usually run the builds testing things within a few minutes, so as long as you are watching the notifications your area of vulnerability isn't that long.
If you pin the versions that's fine too (and as you note, slightly more stable), however just be warned that you will get PRs for every update.
|
@Arcanemagus Thx for review. I'm going to look at https://github.com/atom/ci. |
arusakov
force-pushed
the
coffeelint_and_travis
branch
from
36a224c to
13c92e6
Compare
arusakov
force-pushed
the
coffeelint_and_travis
branch
from
13c92e6 to
51ea12d
Compare
@park9140 I want to setup CI (via https://travis-ci.org/), but admin rights required.
Coffeelint to start. I will add specs in future.