This repository has been archived by the owner on Aug 7, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 23
CI, coffeelint and travis #58
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
language: node_js | ||
node_js: | ||
- "4.1" | ||
env: | ||
- CXX=g++-4.8 | ||
addons: | ||
apt: | ||
sources: | ||
- ubuntu-toolchain-r-test | ||
packages: | ||
- g++-4.8 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,135 @@ | ||
{ | ||
"arrow_spacing": { | ||
"level": "error" | ||
}, | ||
"braces_spacing": { | ||
"level": "ignore", | ||
"spaces": 0, | ||
"empty_object_spaces": 0 | ||
}, | ||
"camel_case_classes": { | ||
"level": "error" | ||
}, | ||
"coffeescript_error": { | ||
"level": "error" | ||
}, | ||
"colon_assignment_spacing": { | ||
"level": "error", | ||
"spacing": { | ||
"left": 0, | ||
"right": 1 | ||
} | ||
}, | ||
"cyclomatic_complexity": { | ||
"level": "ignore", | ||
"value": 10 | ||
}, | ||
"duplicate_key": { | ||
"level": "error" | ||
}, | ||
"empty_constructor_needs_parens": { | ||
"level": "ignore" | ||
}, | ||
"ensure_comprehensions": { | ||
"level": "warn" | ||
}, | ||
"eol_last": { | ||
"level": "error" | ||
}, | ||
"indentation": { | ||
"value": 2, | ||
"level": "error" | ||
}, | ||
"line_endings": { | ||
"level": "error", | ||
"value": "unix" | ||
}, | ||
"max_line_length": { | ||
"value": 80, | ||
"level": "error", | ||
"limitComments": true | ||
}, | ||
"missing_fat_arrows": { | ||
"level": "ignore", | ||
"is_strict": false | ||
}, | ||
"newlines_after_classes": { | ||
"value": 2, | ||
"level": "error" | ||
}, | ||
"no_backticks": { | ||
"level": "error" | ||
}, | ||
"no_debugger": { | ||
"level": "error", | ||
"console": false | ||
}, | ||
"no_empty_functions": { | ||
"level": "error" | ||
}, | ||
"no_empty_param_list": { | ||
"level": "error" | ||
}, | ||
"no_implicit_braces": { | ||
"level": "ignore", | ||
"strict": true | ||
}, | ||
"no_implicit_parens": { | ||
"level": "ignore", | ||
"strict": true | ||
}, | ||
"no_interpolation_in_single_quotes": { | ||
"level": "error" | ||
}, | ||
"no_nested_string_interpolation": { | ||
"level": "warn" | ||
}, | ||
"no_plusplus": { | ||
"level": "error" | ||
}, | ||
"no_private_function_fat_arrows": { | ||
"level": "warn" | ||
}, | ||
"no_stand_alone_at": { | ||
"level": "ignore" | ||
}, | ||
"no_tabs": { | ||
"level": "error" | ||
}, | ||
"no_this": { | ||
"level": "error" | ||
}, | ||
"no_throwing_strings": { | ||
"level": "error" | ||
}, | ||
"no_trailing_semicolons": { | ||
"level": "error" | ||
}, | ||
"no_trailing_whitespace": { | ||
"level": "error", | ||
"allowed_in_comments": false, | ||
"allowed_in_empty_lines": true | ||
}, | ||
"no_unnecessary_double_quotes": { | ||
"level": "error" | ||
}, | ||
"no_unnecessary_fat_arrows": { | ||
"level": "warn" | ||
}, | ||
"non_empty_constructor_needs_parens": { | ||
"level": "ignore" | ||
}, | ||
"prefer_english_operator": { | ||
"level": "ignore", | ||
"doubleNotLevel": "ignore" | ||
}, | ||
"space_operators": { | ||
"level": "ignore" | ||
}, | ||
"spacing_after_comma": { | ||
"level": "ignore" | ||
}, | ||
"transform_messes_up_line_numbers": { | ||
"level": "warn" | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,6 +4,7 @@ requireResolve = require 'resolve' | |
|
||
TSLINT_MODULE_NAME = 'tslint' | ||
|
||
|
||
module.exports = | ||
|
||
config: | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would highly recommend against this, with GreenKeeper enabled on this repo and tests + CI builds enabled all versions will be tested for you. If one of your allowed versions breaks things you will get a PR telling you so, from there you can either pin the version or fix the thing that is broken.
If you pin it like this though you will get a PR for every single update, since it will be outside your allowed range.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Arcanemagus Let me explain some use case:
For example, the
atom-package-deps
has been updated to v4.1.0. v4.1.0 satisfies^4.0.1
and breaks something. So until I am not fixed changes or pinned the version, all new linter-tslint users can get an error. From this point of view - strict versioning is the most stable variant.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Greenkeeper will usually run the builds testing things within a few minutes, so as long as you are watching the notifications your area of vulnerability isn't that long.
If you pin the versions that's fine too (and as you note, slightly more stable), however just be warned that you will get PRs for every update.