This repository has been archived by the owner on Aug 7, 2023. It is now read-only.
make warnings from the validator available rather then ignoring them #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirk-thomas
force-pushed
the
show_problems_with_validation
branch
6 times, most recently
from
a448fc4 to
9c189d8
Compare
| type: 'Error' | ||
| text: output | ||
| filePath: textEditor.getPath() | ||
| range: [[0, 0], [0, 0]] |
There was a problem hiding this comment.
If you omit this range it is still a valid message, linter will show it as associated with the file but not give it a range within the file.
There was a problem hiding this comment.
That's why I always keep my own PRs open for a day or two. You always have a good comment 😉 Thanks - updated in c9e5bf8
dirk-thomas
force-pushed
the
show_problems_with_validation
branch
from
49fc466 to
cb1fbe2
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If e.g.
xmllintfails to access a referenced xml-model file the warning was not visible to the user. If the validation fails the remaining output it always shown in a message.