Fix bug in array_handling.stack_by_init_date
#5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to fix a few bugs in
array_handling.stack_by_init_date
function. I have also changed the API of the function in the following ways:freq
parameter,time
dimension ofds
has the same dtype asinit_dates
. I think this is cleaner than requiring thatinit_dates
is an array of strings,I trialled adding a catch to use the
stride
option in.rolling.contruct
when the initial dates are evenly spaced along the time dimension, but this ended up being overly complicated and didn't really add any performance benefits.I've added some basic tests of the new function and added
pytest
toenvironment.yml
so that these tests can be run.Closes #4